[Password Manager] Send username correction votes

components/autofill/core/common/password_form_fill_data.cc

Index: components/autofill/core/common/password_form_fill_data.cc
diff --git a/components/autofill/core/common/password_form_fill_data.cc b/components/autofill/core/common/password_form_fill_data.cc
index a75d9c5e3cac79f8def31eabcda66818e77f9434..82882dd32a899479bea830448dfe7f17539d7913 100644
--- a/components/autofill/core/common/password_form_fill_data.cc
+++ b/components/autofill/core/common/password_form_fill_data.cc
@@ -11,6 +11,20 @@
 
 namespace autofill {
 
+namespace {
+
+// Extracts username values from |values_and_field_names| and inserts to
+// |values|.
+void InsertUsernameValues(const PossibleUsernamesVector& values_and_field_names,
+                          std::vector<base::string16>* values) {
+  DCHECK(values && values->empty());
+
+  for (auto& pair : values_and_field_names)

[dvadym, 2017/03/22 10:56:18]

Nit: const auto&

[kolos1, 2017/03/22 13:40:39]

Done.

+    values->push_back(pair.first);
+}
+
+}  // namespace
+
 UsernamesCollectionKey::UsernamesCollectionKey() {}
 
 UsernamesCollectionKey::~UsernamesCollectionKey() {}
@@ -84,8 +98,8 @@ void InitPasswordFormFillData(
       if (it.second->is_public_suffix_match ||
           it.second->is_affiliation_based_match)
         key.realm = it.second->signon_realm;
-      result->other_possible_usernames[key] =
-          it.second->other_possible_usernames;
+      InsertUsernameValues(it.second->other_possible_usernames,
+                           &result->other_possible_usernames[key]);

[dvadym, 2017/03/22 10:56:18]

Could you please remove sending OtherPossibleUsername to the renderer at all
(here and in mojo files)? We don't want to show for now OtherPossible usernames
for the user, so we don't need to send them to the renderer. Not sending to the
renderer will help us:
1.To save time/memory
2.To improve security, since less data will be in renderer.

[kolos1, 2017/03/22 13:40:39]

Agree. Created a separate CL for that
(https://codereview.chromium.org/2760353003/)

     }
   }
 }