components/autofill/content/common/autofill_types_struct_traits_unittest.cc - Issue 2747733004: [Password Manager] Send username correction votes

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

Issue 2747733004: [Password Manager] Send username correction votes (Closed)

Patch Set: Changes addressed to reviewer comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/autofill/content/common/autofill_types_struct_traits.cc ('k') | components/autofill/content/renderer/password_form_conversion_utils.cc » ('j') | components/autofill/core/common/password_form.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/autofill/content/common/autofill_types_struct_traits_unittest.cc

diff --git a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

index 59f9bc4a9ce6f8a51b6e03e49f2c448738e6b48f..19d6ac252516f3152b6f56af22c2ab199b5f3001 100644

--- a/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

+++ b/components/autofill/content/common/autofill_types_struct_traits_unittest.cc

@@ -83,8 +83,10 @@ void CreateTestPasswordForm(PasswordForm* form) {

form->username_element = base::ASCIIToUTF16("username");

form->username_marked_by_site = true;

form->username_value = base::ASCIIToUTF16("test@gmail.com");

- form->other_possible_usernames.push_back(base::ASCIIToUTF16("Jerry_1"));

- form->other_possible_usernames.push_back(base::ASCIIToUTF16("Jerry_2"));

+ form->other_possible_usernames.push_back(PossibleUsernamePair(

+ base::ASCIIToUTF16("Jerry_1"), base::ASCIIToUTF16("id1")));

+ form->other_possible_usernames.push_back(PossibleUsernamePair(

+ base::ASCIIToUTF16("Jerry_2"), base::ASCIIToUTF16("id2")));

form->password_element = base::ASCIIToUTF16("password");

form->password_value = base::ASCIIToUTF16("test");

form->password_value_is_default = true;