[Password Manager] Send username correction votes

components/autofill/core/common/password_form.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <ostream>
 #include <sstream>
 
 #include "base/json/json_writer.h"
 #include "base/strings/string16.h"
 #include "base/strings/string_util.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/values.h"
 #include "components/autofill/core/common/password_form.h"
 
 namespace autofill {
 
 namespace {
 
+base::string16 OtherPossibleUsernamesToString(

[vabr (Chromium), 2017/03/16 21:00:42]

You can also implement it as two pass processing:
(1) using std::transform to create a vector of "first+second" strings, then
(2) using base::JoinString to join them with ",".

There are two advantages to using JoinString: it is easier to read than the
for-cycle with the special clause for the non-empty result, and it is also
faster thanks to pre-allocating the needed space upfront.

The disadvantage is that more space is locally taken to store the "first+second"
strings, but at least it is not slower, because the current code on line 25 also
creates all those strings.

[kolos1, 2017/03/17 14:09:34]

Done.

+    PossibleUsernamesVector possible_usernames) {

[vabr (Chromium), 2017/03/16 21:00:42]

const PossibleUsernamesVector&

[kolos1, 2017/03/17 14:09:34]

Done.

+  base::string16 result;
+  for (const PossibleUsernamePair pair : possible_usernames) {

[vabr (Chromium), 2017/03/16 21:00:41]

use const ref not const value:
const PossibleUsernamePair& pair

[kolos1, 2017/03/17 14:09:34]

Done.

+    if (!result.empty())
+      result += base::ASCIIToUTF16(", ");
+    result += pair.first + base::ASCIIToUTF16("+") + pair.second;
+  }
+  return result;
+}
+
 // Serializes a PasswordForm to a JSON object. Used only for logging in tests.
 void PasswordFormToJSON(const PasswordForm& form,
                         base::DictionaryValue* target) {
   target->SetInteger("scheme", form.scheme);
   target->SetString("signon_realm", form.signon_realm);
   target->SetBoolean("is_public_suffix_match", form.is_public_suffix_match);
   target->SetBoolean("is_affiliation_based_match",
                      form.is_affiliation_based_match);
   target->SetString("origin", form.origin.possibly_invalid_spec());
   target->SetString("action", form.action.possibly_invalid_spec());
   target->SetString("submit_element", form.submit_element);
   target->SetString("username_elem", form.username_element);
   target->SetBoolean("username_marked_by_site", form.username_marked_by_site);
   target->SetString("username_value", form.username_value);
   target->SetString("password_elem", form.password_element);
   target->SetString("password_value", form.password_value);
   target->SetBoolean("password_value_is_default",
                      form.password_value_is_default);
   target->SetString("new_password_element", form.new_password_element);
   target->SetString("new_password_value", form.new_password_value);
   target->SetBoolean("new_password_value_is_default",
                      form.new_password_value_is_default);
   target->SetBoolean("new_password_marked_by_site",
                      form.new_password_marked_by_site);
-  target->SetString("other_possible_usernames",
-                    base::JoinString(form.other_possible_usernames,
-                                     base::ASCIIToUTF16("|")));
+  target->SetString(
+      "other_possible_usernames",
+      OtherPossibleUsernamesToString(form.other_possible_usernames));
   target->SetBoolean("blacklisted", form.blacklisted_by_user);
   target->SetBoolean("preferred", form.preferred);
   target->SetDouble("date_created", form.date_created.ToDoubleT());
   target->SetDouble("date_synced", form.date_synced.ToDoubleT());
   target->SetInteger("type", form.type);
   target->SetInteger("times_used", form.times_used);
   std::ostringstream form_data_string_stream;
   form_data_string_stream << form.form_data;
   target->SetString("form_data", form_data_string_stream.str());
   target->SetInteger("generation_upload_status", form.generation_upload_status);
@@ skipping 144 matching lines @@
   base::JSONWriter::WriteWithOptions(
       form_json, base::JSONWriter::OPTIONS_PRETTY_PRINT, &form_as_string);
   base::TrimWhitespaceASCII(form_as_string, base::TRIM_ALL, &form_as_string);
   return os << "PasswordForm(" << form_as_string << ")";
 }
 
 std::ostream& operator<<(std::ostream& os, PasswordForm* form) {
   return os << "&" << *form;
 }
 
+base::string16 OtherPossibleUsernamesToStr(const PasswordForm& form) {
+  return OtherPossibleUsernamesToString(form.other_possible_usernames);
+}
+
 }  // namespace autofill