Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Unified Diff: pkg/dev_compiler/lib/src/compiler/compiler.dart

Issue 2747733003: Do not return the JSON as an escaped String to work around a strange v8 bug. (Closed)
Patch Set: Do not return the JSON as an escaped String to work around a strange v8 bug. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | pkg/dev_compiler/web/stack_trace_mapper.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/dev_compiler/lib/src/compiler/compiler.dart
diff --git a/pkg/dev_compiler/lib/src/compiler/compiler.dart b/pkg/dev_compiler/lib/src/compiler/compiler.dart
index 93389ab2f94fa20b4694ef25cfc671cf8c2f56ca..e2808bf56caede3b97945a3965ac8de531bb90f8 100644
--- a/pkg/dev_compiler/lib/src/compiler/compiler.dart
+++ b/pkg/dev_compiler/lib/src/compiler/compiler.dart
@@ -509,11 +509,7 @@ class JSModuleFile {
}
var text = printer.getText();
- var rawSourceMap = options.inlineSourceMap ? JSON.encode(builtMap) : null;
- // Encode the sourcemap as an escaped string rather than JSON
- // as Dart code using the sourcemap can't take advantage of it being JS
- // JSON so we might as well encode it as a String which should be quicker
- // to parse.
+ var rawSourceMap = options.inlineSourceMap ? builtMap : null;
text = text.replaceFirst(sourceMapHoleID, JSON.encode(rawSourceMap));
return new JSModuleCode(text, builtMap);
« no previous file with comments | « no previous file | pkg/dev_compiler/web/stack_trace_mapper.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698