Issue 2747733003: Do not return the JSON as an escaped String to work around a strange v8 bug.

Issue 2747733003: Do not return the JSON as an escaped String to work around a strange v8 bug. (Closed)

Created:
3 years, 9 months ago by Jacob

Modified:
3 years, 9 months ago

Reviewers:
vsm

CC:
dev-compiler+reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Do not return the JSON as an escaped String to work around a strange v8 bug. This makes the source files a little easier to read anyway and the JSON is not typically that nested so there should be a minimal statup performance hit. Do not return the JSON as an escaped String to work around a strange v8 bug. BUG= R=vsm@google.com Committed: https://github.com/dart-lang/sdk/commit/c9675aeefb0d8526f0e414a4e26a08e4ded8aa09

Patch Set 1 #

Patch Set 2 : Do not return the JSON as an escaped String to work around a strange v8 bug. #

Created: 3 years, 9 months ago

(Patch set is too large to download)

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -6 lines)			Patch
	M	pkg/dev_compiler/lib/src/compiler/compiler.dart	View	1	1 chunk	+1 line, -5 lines	0 comments	Download
	M	pkg/dev_compiler/web/stack_trace_mapper.dart	View	1	3 chunks	+8 lines, -1 line	0 comments	Download

Messages

Total messages: 5 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Jacob

3 years, 9 months ago (2017-03-13 22:49:16 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:10001) manually as
c9675aeefb0d8526f0e414a4e26a08e4ded8aa09 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages