Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(662)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: ios/web_view/public/cwv_web_view_configuration.h

Issue 2747683002: Merge CWVWebsiteDataStore into CWVWebViewConfiguration. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« ios/web_view/internal/cwv_web_view_configuration.mm ('K') | « ios/web_view/public/BUILD.gn ('k') | ios/web_view/public/cwv_website_data_store.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web_view/public/cwv_web_view_configuration.h
diff --git a/ios/web_view/public/cwv_web_view_configuration.h b/ios/web_view/public/cwv_web_view_configuration.h
index aa4b96f0083de2d401bd49cf8662327bcbb28653..1c390059a869203fd5ac24e66bc5a7d796fdffde 100644
--- a/ios/web_view/public/cwv_web_view_configuration.h
+++ b/ios/web_view/public/cwv_web_view_configuration.h
@@ -12,9 +12,17 @@
// Configuration used for creation of a CWVWebView.
@interface CWVWebViewConfiguration : NSObject<NSCopying>
-// Data store defining persistance of website data. Default is
-// [CWVWebsiteDataStore defaultDataStore].
-@property(nonatomic, strong, nonnull) CWVWebsiteDataStore* websiteDataStore;
+// Configuration with persistent data store which stores
michaeldo 2017/03/13 14:54:02 Please re-wrap comments for these two static metho
Hiroshi Ichikawa 2017/03/16 05:38:57 Done.
+// all data on disk.
++ (instancetype)defaultConfiguration;
+
+// Configuration with ephemeral data store that neven stores
+// data on disk.
++ (instancetype)incognitoConfiguration;
+
+- (instancetype)init NS_UNAVAILABLE;
+
+@property(readonly, getter=isPersistent) BOOL persistent;
michaeldo 2017/03/13 14:54:02 Please add comment.
Hiroshi Ichikawa 2017/03/16 05:38:57 Done.
@end
« ios/web_view/internal/cwv_web_view_configuration.mm ('K') | « ios/web_view/public/BUILD.gn ('k') | ios/web_view/public/cwv_website_data_store.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698