Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(437)

Issue 27476003: IDL compiler: [Unforgeable] (Closed)

Created:
7 years, 2 months ago by Nils Barth (inactive)
Modified:
7 years, 2 months ago
Reviewers:
haraken
CC:
blink-reviews, Nils Barth (inactive), kojih, jsbell+bindings_chromium.org, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, Nate Chapin, Inactive, kouhei (in TOK)
Visibility:
Public.

Description

IDL compiler: [Unforgeable] Straightforward, same "Remove superfluous default" as with property attributes (in Perl too), in this case v8::DEFAULT. Docs: https://sites.google.com/a/chromium.org/dev/blink/webidl/blink-idl-extended-attributes#TOC-Unforgeable-m-a- BUG=239771 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=159843

Patch Set 1 #

Patch Set 2 : Rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -16 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 1 chunk +8 lines, -7 lines 0 comments Download
M Source/bindings/scripts/unstable/v8_attributes.py View 1 2 chunks +14 lines, -8 lines 0 comments Download
M Source/bindings/templates/attributes.cpp View 1 2 chunks +7 lines, -1 line 0 comments Download
M Source/bindings/tests/idls/TestObjectPython.idl View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 chunks +17 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Nils Barth (inactive)
Quick one, some Perl changes.
7 years, 2 months ago (2013-10-16 08:10:55 UTC) #1
haraken
LGTM
7 years, 2 months ago (2013-10-16 08:16:25 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nbarth@chromium.org/27476003/4001
7 years, 2 months ago (2013-10-17 01:36:08 UTC) #3
commit-bot: I haz the power
7 years, 2 months ago (2013-10-17 08:36:55 UTC) #4
Message was sent while issue was closed.
Change committed as 159843

Powered by Google App Engine
This is Rietveld 408576698