Issue 2747583004: Don't leave a caret selection after RevertAll.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2747583004: Don't leave a caret selection after RevertAll. (Closed)

Created:
3 years, 9 months ago by Charlie Reis

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, jdonnelly+watch_chromium.org, tfarina

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Don't leave a caret selection after RevertAll. BUG=681740 TEST=See bug for repro steps.

Patch Set 1 #

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -0 lines)			Patch
	M	chrome/browser/ui/views/omnibox/omnibox_view_views.cc	View		1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 5 (5 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Charlie Reis

The CQ bit was checked by creis@chromium.org to run a CQ dry run

3 years, 9 months ago (2017-03-11 20:29:05 UTC) #1

commit-bot: I haz the power

Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2747583004/1

3 years, 9 months ago (2017-03-11 20:29:12 UTC) #2

commit-bot: I haz the power

The CQ bit was unchecked by commit-bot@chromium.org

3 years, 9 months ago (2017-03-11 21:02:53 UTC) #3

commit-bot: I haz the power

Dry run: Try jobs failed on following builders: win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/382696)

3 years, 9 months ago (2017-03-11 21:02:54 UTC) #4

Charlie Reis

3 years, 5 months ago (2017-07-11 22:35:09 UTC) #5

Description was changed from

==========
Don't leave a caret selection after RevertAll.

BUG=681740
TEST=See bug for repro steps.
==========

to

==========
Don't leave a caret selection after RevertAll.

BUG=681740
TEST=See bug for repro steps.
==========

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages