Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 2747583003: Parse factory constructors with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov
Modified:
3 years, 9 months ago
Reviewers:
ahe, Paul Berry
CC:
reviews_dartlang.org, dart-fe-team+reviews_google.com
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+123 lines, -53 lines) Patch
M pkg/analyzer/lib/src/summary/fasta/summary_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/parser_fasta_test.dart View 2 chunks +0 lines, -21 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 3 chunks +47 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/front_end/lib/src/fasta/analyzer/ast_builder.dart View 3 chunks +61 lines, -0 lines 0 comments Download
M pkg/front_end/lib/src/fasta/parser/listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/parser/parser.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/diet_listener.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/front_end/lib/src/fasta/source/outline_builder.dart View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
scheglov
3 years, 9 months ago (2017-03-11 19:51:01 UTC) #1
Paul Berry
lgtm
3 years, 9 months ago (2017-03-12 13:50:31 UTC) #2
scheglov
Committed patchset #1 (id:1) manually as 98c52157dc297b2b53679fbd96453793dd112bf0 (presubmit successful).
3 years, 9 months ago (2017-03-12 16:56:49 UTC) #4
ahe
3 years, 9 months ago (2017-03-13 11:54:09 UTC) #5
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698