[DevTools] Rework Popover API

third_party/WebKit/Source/devtools/front_end/timeline/TimelineUIUtils.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  * Copyright (C) 2012 Intel Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
@@ skipping 676 matching lines @@
     if (!maybeTarget) {
       return Timeline.TimelineUIUtils._buildTraceEventDetailsSynchronously(
           event, model, linkifier, detailed, null);
     }
 
     var target = /** @type {!SDK.Target} */ (maybeTarget);
     if (!event[Timeline.TimelineUIUtils._previewElementSymbol]) {
       var url = TimelineModel.TimelineData.forEvent(event).url;
       event[Timeline.TimelineUIUtils._previewElementSymbol] = await new Promise(fulfill => {
         if (url)
-          Components.DOMPresentationUtils.buildImagePreviewContents(target, url, false, fulfill);
+          Components.DOMPresentationUtils.buildImagePreviewContents(target, url, false).then(fulfill);
         else if (TimelineModel.TimelineData.forEvent(event).picture)
           Timeline.TimelineUIUtils.buildPicturePreviewContent(event, target, fulfill);
         else
           fulfill();
       }) || null;
     }
 
     var nodeIdsToResolve = new Set();
     var timelineData = TimelineModel.TimelineData.forEvent(event);
     if (timelineData.backendNodeId)
@@ skipping 416 matching lines @@
           if (link)
             contentHelper.appendElementRow(title, link);
         }
       }
     }
 
     /**
      * @param {function(?Element)} fulfill
      */
     function action(fulfill) {
-      Components.DOMPresentationUtils.buildImagePreviewContents(
-          /** @type {!SDK.Target} */ (target), request.url, false, saveImage);
+      Components.DOMPresentationUtils
+          .buildImagePreviewContents(
+              /** @type {!SDK.Target} */ (target), request.url, false)
+          .then(saveImage);
       /**
-       * @param {!Element=} element
+       * @param {?Element} element
        */
       function saveImage(element) {
-        request.previewElement = element || null;
+        request.previewElement = element;
         fulfill(request.previewElement);
       }
     }
     var previewPromise;
     if (request.previewElement)
       previewPromise = Promise.resolve(request.previewElement);
     else
       previewPromise = request.url && target ? new Promise(action) : Promise.resolve(null);
     /**
      * @param {?Element} element
@@ skipping 1149 matching lines @@
    * @param {string=} warningType
    */
   appendWarningRow(event, warningType) {
     var warning = Timeline.TimelineUIUtils.eventWarning(event, warningType);
     if (warning)
       this.appendElementRow(Common.UIString('Warning'), warning, true);
   }
 };
 
 Timeline.TimelineUIUtils._categoryBreakdownCacheSymbol = Symbol('categoryBreakdownCache');