[DevTools] Rework Popover API

third_party/WebKit/Source/devtools/front_end/profiler/HeapSnapshotGridNodes.js

 /*
  * Copyright (C) 2011 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 115 matching lines @@
     if (this._providerObject)
       this._providerObject.dispose();
     for (var node = this.children[0]; node; node = node.traverseNextNode(true, this, true)) {
       if (node.dispose)
         node.dispose();
     }
   }
 
   /**
    * @param {!SDK.Target} target
-   * @param {function(!SDK.RemoteObject)} callback
    * @param {string} objectGroupName
+   * @return {!Promise<!SDK.RemoteObject>}
    */
-  queryObjectContent(target, callback, objectGroupName) {
+  queryObjectContent(target, objectGroupName) {
   }
 
   /**
    * @override
    */
   wasDetached() {
     this._dataGrid.nodeWasDetached(this);
   }
 
   /**
@@ skipping 448 matching lines @@
     cell.heapSnapshotNode = this;
     return cell;
   }
 
   _prefixObjectCell(div) {
   }
 
   /**
    * @override
    * @param {!SDK.Target} target
-   * @param {function(!SDK.RemoteObject)} callback
    * @param {string} objectGroupName
+   * @return {!Promise<!SDK.RemoteObject>}
    */
-  queryObjectContent(target, callback, objectGroupName) {
+  queryObjectContent(target, objectGroupName) {
+    var fulfill;
+    var promise = new Promise(x => fulfill = x);
+
     /**
      * @param {?SDK.RemoteObject} object
      */
     function onResult(object) {
-      callback(
+      fulfill(
           object ||
           target.runtimeModel.createRemoteObjectFromPrimitiveValue(Common.UIString('Preview is not available')));
     }
 
     var heapProfilerModel = target.model(SDK.HeapProfilerModel);
     if (this._type === 'string')
       onResult(target.runtimeModel.createRemoteObjectFromPrimitiveValue(this._name));
     else if (!heapProfilerModel)
       onResult(null);
     else
       heapProfilerModel.objectForSnapshotObjectId(String(this.snapshotNodeId), objectGroupName).then(onResult);
+    return promise;
   }
 
   updateHasChildren() {
     /**
      * @this {Profiler.HeapSnapshotGenericObjectNode}
      */
     function isEmptyCallback(isEmpty) {
       this.setHasChildren(!isEmpty);
     }
     this._provider().isEmpty(isEmptyCallback.bind(this));
@@ skipping 803 matching lines @@
     return cell;
   }
 
   /**
    * @return {number}
    */
   allocationNodeId() {
     return this._allocationNode.id;
   }
 };