[DevTools] Rework Popover API

third_party/WebKit/Source/devtools/front_end/perf_ui/TimelineOverviewPane.js

 /*
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 35 matching lines @@
     this._cursorElement = this._overviewGrid.element.createChild('div', 'overview-grid-cursor-position');
     this._cursorArea.addEventListener('mousemove', this._onMouseMove.bind(this), true);
     this._cursorArea.addEventListener('mouseleave', this._hideCursor.bind(this), true);
 
     this._overviewGrid.setResizeEnabled(false);
     this._overviewGrid.addEventListener(PerfUI.OverviewGrid.Events.WindowChanged, this._onWindowChanged, this);
     this._overviewGrid.setClickHandler(this._onClick.bind(this));
     this._overviewControls = [];
     this._markers = new Map();
 
-    this._popoverHelper = new UI.PopoverHelper(this._cursorArea);
-    this._popoverHelper.initializeCallbacks(
-        this._getPopoverAnchor.bind(this), this._showPopover.bind(this), this._onHidePopover.bind(this));
+    this._popoverHelper = new UI.PopoverHelper(this._cursorArea, this._getPopoverRequest.bind(this));
     this._popoverHelper.setHasPadding(true);
     this._popoverHelper.setTimeout(0);
 
     this._updateThrottler = new Common.Throttler(100);
 
     this._cursorEnabled = false;
     this._cursorPosition = 0;
     this._lastWidth = 0;
   }
 
   /**
-   * @param {!Element} element
    * @param {!Event} event
-   * @return {!Element|!AnchorBox|undefined}
+   * @return {?UI.PopoverRequest}
    */
-  _getPopoverAnchor(element, event) {
-    return this._cursorArea;
+  _getPopoverRequest(event) {
+    return {
+      box: this._cursorElement.boxInWindow(),
+      show: popover => this._buildPopoverContents().then(fragment => {
+        if (!fragment.firstChild)
+          return false;
+        var content = new PerfUI.TimelineOverviewPane.PopoverContents();
+        this._popoverContents = content.contentElement.createChild('div');
+        this._popoverContents.appendChild(fragment);
+        this._popover = popover;
+        content.show(popover.contentElement);
+        return true;
+      }),
+      hide: () => {
+        this._popover = null;
+        this._popoverContents = null;
+      }
+    };
   }
 
   /**
-   * @param {!Element|!AnchorBox} anchor
-   * @param {!UI.GlassPane} popover
-   * @return {!Promise<boolean>}
-   */
-  _showPopover(anchor, popover) {
-    return this._buildPopoverContents().then(maybeShowPopover.bind(this));
-
-    /**
-     * @this {PerfUI.TimelineOverviewPane}
-     * @param {!DocumentFragment} fragment
-     * @return {boolean}
-     */
-    function maybeShowPopover(fragment) {
-      if (!fragment.firstChild)
-        return false;
-      var content = new PerfUI.TimelineOverviewPane.PopoverContents();
-      this._popoverContents = content.contentElement.createChild('div');
-      this._popoverContents.appendChild(fragment);
-      this._popover = popover;
-      content.show(popover.contentElement);
-      return true;
-    }
-  }
-
-  _onHidePopover() {
-    this._popover = null;
-    this._popoverContents = null;
-  }
-
-  /**
    * @param {!Event} event
    */
   _onMouseMove(event) {
     if (!this._cursorEnabled)
       return;
     this._cursorPosition = event.offsetX + event.target.offsetLeft;
     this._cursorElement.style.left = this._cursorPosition + 'px';
     this._cursorElement.style.visibility = 'visible';
     if (!this._popover)
       return;
@@ skipping 425 matching lines @@
    */
   onClick(event) {
     return false;
   }
 
   resetCanvas() {
     this._canvas.width = this.element.clientWidth * window.devicePixelRatio;
     this._canvas.height = this.element.clientHeight * window.devicePixelRatio;
   }
 };