chrome/browser/chromeos/login/ui/login_display_host_impl.cc - Issue 2747543002: ash: Start/stop observing KeyboardController via ShellObserver

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

Issue 2747543002: ash: Start/stop observing KeyboardController via ShellObserver (Closed)

Patch Set: pass root_window to OnVirtualKeyboardStateChanged() Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/chromeos/login/ui/login_display_host_impl.cc

diff --git a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

index cfa9e34d1c171616c9330a9b634ad4cf0a84a0a3..99d1d9801a6ba4c80c1625f1b13c7945a4310d70 100644

--- a/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

+++ b/chrome/browser/chromeos/login/ui/login_display_host_impl.cc

@@ -1028,7 +1028,9 @@ void LoginDisplayHostImpl::OnActiveOutputNodeChanged() {

////////////////////////////////////////////////////////////////////////////////

// LoginDisplayHostImpl, ash::ShellObserver:

-void LoginDisplayHostImpl::OnVirtualKeyboardStateChanged(bool activated) {

+void LoginDisplayHostImpl::OnVirtualKeyboardStateChanged(

+ bool activated,

+ ash::WmWindow* root_window) {

if (keyboard::KeyboardController::GetInstance()) {

if (activated) {

if (!is_observing_keyboard_) {