Ignores mouse motion events when mouse is pressed or drag and drop is in progress

ui/views/corewm/tooltip_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/views/corewm/tooltip_controller.h"
 
 #include <vector>
 
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
@@ skipping 167 matching lines @@
     TooltipShownTimerFired();
   }
 }
 
 void TooltipController::OnMouseEvent(ui::MouseEvent* event) {
   switch (event->type()) {
     case ui::ET_MOUSE_CAPTURE_CHANGED:
     case ui::ET_MOUSE_EXITED:
     case ui::ET_MOUSE_MOVED:
     case ui::ET_MOUSE_DRAGGED: {
+      if (!tooltips_enabled_ ||

[sky, 2014/05/20 20:43:22]

I think this early out is too early. You still want to hide the tooltip, stop
the timer and other stuff.

[varkha, 2014/05/20 21:12:26]

You are right - for the capture changes and mouse exits this needs to be done
here.

+          aura::Env::GetInstance()->IsMouseButtonDown() ||
+          IsDragDropInProgress()) {
+        break;
+      }
+
       curr_mouse_loc_ = event->location();
       aura::Window* target = GetTooltipTarget(*event, &curr_mouse_loc_);
       SetTooltipWindow(target);
       if (tooltip_timer_.IsRunning())
         tooltip_timer_.Reset();
 
       if (tooltip_->IsVisible())
         UpdateIfRequired();
       break;
     }
@@ skipping 146 matching lines @@
     return;
   if (tooltip_window_)
     tooltip_window_->RemoveObserver(this);
   tooltip_window_ = target;
   if (tooltip_window_)
     tooltip_window_->AddObserver(this);
 }
 
 }  // namespace corewm
 }  // namespace views