Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(318)

Unified Diff: tracing/tracing/ui/side_panel/metrics_side_panel_test.html

Issue 2747453003: Refactor histogram-set-view to an MVC pattern. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/side_panel/metrics_side_panel_test.html
diff --git a/tracing/tracing/ui/side_panel/metrics_side_panel_test.html b/tracing/tracing/ui/side_panel/metrics_side_panel_test.html
index 0d6f88a467d6fb560ea38d57c3b76c0ffd9d9ac2..93f50ccd39f53f76b39aaa110076c7ab2006acbc 100644
--- a/tracing/tracing/ui/side_panel/metrics_side_panel_test.html
+++ b/tracing/tracing/ui/side_panel/metrics_side_panel_test.html
@@ -37,11 +37,11 @@ tr.b.unittest.testSuite(function() {
tr.metrics.MetricRegistry.register(testMetric);
- test('instantiateCollapsed', function() {
+ test('instantiateCollapsed', async function() {
var metricsPanel = document.createElement('tr-ui-sp-metrics-side-panel');
- metricsPanel.currentMetricName_ = 'testMetric';
- metricsPanel.model = createModel();
this.addHTMLOutput(metricsPanel);
+ metricsPanel.currentMetricName_ = 'testMetric';
+ await metricsPanel.build(createModel());
assert.isDefined(tr.b.findDeepElementMatchingPredicate(
metricsPanel, elem => elem.textContent === 'test histogram'));
« no previous file with comments | « tracing/tracing/ui/side_panel/metrics_side_panel.html ('k') | tracing/tracing/value/histogram_importer.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698