Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: tracing/tracing/base/view_state.html

Issue 2747453003: Refactor histogram-set-view to an MVC pattern. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/base/iteration_helpers.html ('k') | tracing/tracing/ui/side_panel/metrics_side_panel.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/base/view_state.html
diff --git a/tracing/tracing/base/view_state.html b/tracing/tracing/base/view_state.html
index 755400a15cfc88ee615e7de1d6cf44052cb001e2..a64bbc591fbad75612aee138a9284dfeb1dacdc6 100644
--- a/tracing/tracing/base/view_state.html
+++ b/tracing/tracing/base/view_state.html
@@ -37,9 +37,13 @@ tr.exportTo('tr.b', function() {
this.update(new Map([[name, value]]));
}
+ async updateFromViewState(other) {
+ await this.update(other.properties_);
+ }
+
/**
- * Updates fields, and, if any of them actually changed, dispatches
- * an event with Map detail.delta.
+ * Updates properties, and, if any of them actually changed, dispatches
+ * an event with delta = {propertyName: {previous, current}}.
*
* @param {!(Object|Map)} delta
*/
« no previous file with comments | « tracing/tracing/base/iteration_helpers.html ('k') | tracing/tracing/ui/side_panel/metrics_side_panel.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698