Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4993)

Unified Diff: chrome/android/java/res/values/ids.xml

Issue 2747453002: Split context menu display and population/handling (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/res/values/ids.xml
diff --git a/chrome/android/java/res/values/ids.xml b/chrome/android/java/res/values/ids.xml
index eda12d62693ad51d33f8c2d85f03077236f97d76..c6b15c2dee57f7dca3f83f79c6cce4733d3f7bd4 100644
--- a/chrome/android/java/res/values/ids.xml
+++ b/chrome/android/java/res/values/ids.xml
@@ -38,9 +38,6 @@
<item type="id" name="menu_id_refresh" />
<item type="id" name="menu_id_settings" />
- <!-- Menu item IDs for FullscreenActivities -->
- <item type="id" name="menu_id_open_in_chrome" />
-
<!-- Cast notification -->
<item type="id" name="remote_notification" />
@@ -70,4 +67,34 @@
<!-- Password update prompt -->
<item type="id" name="password_infobar_accounts_spinner" />
+
+ <!-- Context Menu Ids -->
+ <!-- Custom Tab Group -->
+ <item type="id" name="contextmenu_open_in_new_chrome_tab" />
JJ 2017/03/10 18:01:16 Any objections to me moving this from contextmenu.
Ted C 2017/03/11 00:31:14 Nope...go for it
+ <item type="id" name="contextmenu_open_in_chrome_incognito_tab" />
+ <item type="id" name="contextmenu_open_in_browser_id" />
+ <!-- Link Group -->
+ <item type="id" name="contextmenu_open_in_other_window" />
+ <item type="id" name="contextmenu_open_in_new_tab" />
+ <item type="id" name="contextmenu_open_in_incognito_tab" />
+ <item type="id" name="contextmenu_copy_link_address" />
+ <item type="id" name="contextmenu_copy_link_text" />
+ <item type="id" name="contextmenu_save_link_as" />
+ <!--Image Group -->
+ <item type="id" name="contextmenu_load_original_image" />
+ <item type="id" name="contextmenu_save_image" />
+ <item type="id" name="contextmenu_open_image" />
+ <item type="id" name="contextmenu_open_image_in_new_tab" />
+ <item type="id" name="contextmenu_search_by_image" />
+ <item type="id" name="contextmenu_share_image" />
+ <!-- Message Group -->
+ <item type="id" name="contextmenu_call" />
+ <item type="id" name="contextmenu_send_message" />
+ <item type="id" name="contextmenu_add_to_contacts" />
+ <item type="id" name="contextmenu_copy" />
+ <!-- Other Group -->
+ <item type="id" name="contextmenu_save_video" />
+ <!-- Menu item IDs for FullscreenActivities -->
+ <item type="id" name="menu_id_open_in_chrome" />
+
</resources>

Powered by Google App Engine
This is Rietveld 408576698