Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(153)

Unified Diff: net/quic/core/quic_connection_test.cc

Issue 2747443002: Landing recent QUIC changes until Sun Mar 5 09:18:09 2017 +0000 (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/core/quic_connection_test.cc
diff --git a/net/quic/core/quic_connection_test.cc b/net/quic/core/quic_connection_test.cc
index b567e4a70a99d8ea6b966999e3de93aafb5e11b9..51e9f28f1bcd287f205396d3b3893305d0548aff 100644
--- a/net/quic/core/quic_connection_test.cc
+++ b/net/quic/core/quic_connection_test.cc
@@ -929,10 +929,6 @@ class QuicConnectionTest : public ::testing::TestWithParam<TestParams> {
ProcessFramePacket(QuicFrame(frame));
}
- void ProcessPathClosePacket(QuicPathCloseFrame* frame) {
- ProcessFramePacket(QuicFrame(frame));
- }
-
bool IsMissing(QuicPacketNumber number) {
return IsAwaitingPacket(*outgoing_ack(), number, 0);
}
@@ -4847,8 +4843,6 @@ TEST_P(QuicConnectionTest, OnPacketHeaderDebugVisitor) {
}
TEST_P(QuicConnectionTest, Pacing) {
- // static_cast here does not work if using multipath_sent_packet_manager.
- FLAGS_quic_reloadable_flag_quic_enable_multipath = false;
TestConnection server(connection_id_, kSelfAddress, helper_.get(),
alarm_factory_.get(), writer_.get(),
Perspective::IS_SERVER, version());
@@ -4979,32 +4973,6 @@ TEST_P(QuicConnectionTest, SendingUnencryptedStreamDataFails) {
EXPECT_FALSE(connection_.connected());
}
-TEST_P(QuicConnectionTest, EnableMultipathNegotiation) {
- // Test multipath negotiation during crypto handshake. Multipath is enabled
- // when both endpoints enable multipath.
- FLAGS_quic_reloadable_flag_quic_enable_multipath = true;
- EXPECT_TRUE(connection_.connected());
- EXPECT_FALSE(QuicConnectionPeer::IsMultipathEnabled(&connection_));
- EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _));
- QuicConfig config;
- // Enable multipath on server side.
- config.SetMultipathEnabled(true);
-
- // Create a handshake message enables multipath.
- CryptoHandshakeMessage msg;
- string error_details;
- QuicConfig client_config;
- // Enable multipath on client side.
- client_config.SetMultipathEnabled(true);
- client_config.ToHandshakeMessage(&msg);
- const QuicErrorCode error =
- config.ProcessPeerHello(msg, CLIENT, &error_details);
- EXPECT_EQ(QUIC_NO_ERROR, error);
-
- connection_.SetFromConfig(config);
- EXPECT_TRUE(QuicConnectionPeer::IsMultipathEnabled(&connection_));
-}
-
TEST_P(QuicConnectionTest, OnPathDegrading) {
QuicByteCount packet_size;
const size_t kMinTimeoutsBeforePathDegrading = 2;

Powered by Google App Engine
This is Rietveld 408576698