Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Issue 2747373005: SPv2: Enable svg animate-elem tests. (Closed)

Created:
3 years, 9 months ago by wkorman
Modified:
3 years, 7 months ago
Reviewers:
pdr.
CC:
chromium-reviews, shans, rjwright, blink-reviews-animation_chromium.org, darktears, blink-reviews, Eric Willigers
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

SPv2: Enable svg animate-elem tests. BUG=666986

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M third_party/WebKit/LayoutTests/FlagExpectations/enable-slimming-paint-v2 View 1 chunk +0 lines, -14 lines 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-04-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-07-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-33-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-34-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-37-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-41-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-78-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-81-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-82-t-expected.png View Binary file 0 comments Download
A third_party/WebKit/LayoutTests/flag-specific/enable-slimming-paint-v2/svg/W3C-SVG-1.1/animate-elem-83-t-expected.png View Binary file 0 comments Download

Messages

Total messages: 4 (2 generated)
wkorman
Similar to https://codereview.chromium.org/2751023003/ These looked the same to me with minor pixel differences perhaps due ...
3 years, 9 months ago (2017-03-15 21:56:32 UTC) #2
pdr.
3 years, 9 months ago (2017-03-15 22:20:48 UTC) #3
On 2017/03/15 at 21:56:32, wkorman wrote:
> Similar to https://codereview.chromium.org/2751023003/
> 
> These looked the same to me with minor pixel differences perhaps due to
> layerization. I kicked off a try job so that we can review again together.
> 
> I noticed FlagExpectations/enable-slimming-paint-v2 has a comment block
> near bottom documenting specific tests where we rebaselined for
> flag-specific with a note as to why.
> Should I add these there before submit?

Having a different set of pixel baselines will be hard to maintain so I'd like
to only use these in cases where we really have to. Do you know why we're not
pixel perfect in these cases?

Powered by Google App Engine
This is Rietveld 408576698