Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html

Issue 2747353002: Make BeforeInstallPromptEvent cancelable (Closed)
Patch Set: Comments Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html
diff --git a/third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html b/third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html
index f8763d2f686f135e411d1d8882854455692fba46..1f993adfe884edeac5e77c5f7dfedd362f8dcf2f 100644
--- a/third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html
+++ b/third_party/WebKit/LayoutTests/app_banner/before-install-prompt-event-constructor.html
@@ -5,9 +5,14 @@
test(function() {
assert_false(new BeforeInstallPromptEvent('eventType').bubbles, 'bubbles');
- assert_true(new BeforeInstallPromptEvent('eventType').cancelable, 'cancelable');
+ assert_false(new BeforeInstallPromptEvent('eventType').cancelable, 'cancelable');
}, 'No initializer passed');
+test(function() {
+ assert_true(new BeforeInstallPromptEvent('eventType', { bubbles: true } ).bubbles, 'bubbles');
+ assert_true(new BeforeInstallPromptEvent('eventType', { cancelable: true } ).cancelable, 'cancelable');
+}, 'Initializer values not respected');
+
test(function() {
var event = new BeforeInstallPromptEvent('eventType', { platforms: ['a'] });
assert_array_equals(['a'], event.platforms, 'platforms');
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/app_banner/BeforeInstallPromptEvent.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698