third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html - Issue 2747333003: Make Document.createTouch arguments non-optional

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/fast/events/touch/touch-event-dispatch-no-crash.html

Issue 2747333003: Make Document.createTouch arguments non-optional (Closed)

Patch Set: Updated layout tests for document-create-touch Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <script src="../../../resources/js-test.js"></script>	2 <script src="../../../resources/js-test.js"></script>

3	3

4 <p id="description"></p>	4 <p id="description"></p>

5 <div id="console"></div>	5 <div id="console"></div>

6 <script type="text/javascript">	6 <script type="text/javascript">

7 description('Test that touches created with no target does not crash during disp atch. http://crbug.com/517962');	7 description('Test that touches created with no target does not crash during disp atch. http://crbug.com/517962');

8	8

	9 var box = document.createElement("div");
	foolip 2017/03/21 08:01:13 Why these changes? Just adding null and 0 argument Why these changes? Just adding null and 0 arguments to the createTouch call should suffice. lunalu1 2017/03/21 19:19:27 Done. Show quoted text On 2017/03/21 08:01:13, foolip_UTC9 wrote: > Why these changes? Just adding null and 0 arguments to the createTouch call > should suffice. Done.
	10 box.id = "box";

	11 box.style.width = "100px";

	12 box.style.height = "100px";

	13 document.body.appendChild(box);

	14

	15 var target = document.getElementById("box");

9 var event = new TouchEvent('touchstart', {	16 var event = new TouchEvent('touchstart', {

10 touches: [document.createTouch()],	17 touches: [document.createTouch(window, target, 1, 100, 101, 102, 103)],

11 });	18 });

12 document.body.dispatchEvent(event);	19 document.body.dispatchEvent(event);

13	20

14 </script>	21 </script>

OLD	NEW