components/content_settings/core/common/content_settings.cc - Issue 2747313002: PasswordProtectionService verdict cache management

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/content_settings/core/common/content_settings.cc

Issue 2747313002: PasswordProtectionService verdict cache management (Closed)

Patch Set: Address lpz's comments Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/content_settings/core/common/content_settings.cc

diff --git a/components/content_settings/core/common/content_settings.cc b/components/content_settings/core/common/content_settings.cc

index ec1621532d923046acf5d916aaf72ed060168235..1dbb41f17d74f47b5e263394dad9fa9053b06020 100644

--- a/components/content_settings/core/common/content_settings.cc

+++ b/components/content_settings/core/common/content_settings.cc

@@ -55,6 +55,7 @@ ContentSettingsType kHistogramOrder[] = {

CONTENT_SETTINGS_TYPE_DEFAULT, // KEYGEN (removed).

CONTENT_SETTINGS_TYPE_BLUETOOTH_GUARD,

CONTENT_SETTINGS_TYPE_BACKGROUND_SYNC,

+ CONTENT_SETTINGS_TYPE_PASSWORD_PROTECTION,

raymes 2017/03/16 00:38:37 This should go right at the end but you may want t

Jialiu Lin 2017/03/16 17:48:19 Sure. I'll wait for the https://codereview.chromiu

CONTENT_SETTINGS_TYPE_AUTOPLAY,

CONTENT_SETTINGS_TYPE_DEFAULT, // PROMPT_NO_DECISION_COUNT (migrated).

CONTENT_SETTINGS_TYPE_IMPORTANT_SITE_INFO,