Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(818)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: components/safe_browsing/csd.proto

Issue 2747313002: PasswordProtectionService verdict cache management (Closed)
Patch Set: refine comment in csd.proto Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/content_settings/core/common/content_settings_types.h ('k') | components/safe_browsing/password_protection/BUILD.gn » ('j') | components/safe_browsing/password_protection/password_protection_service.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/safe_browsing/csd.proto
diff --git a/components/safe_browsing/csd.proto b/components/safe_browsing/csd.proto
index 3da6cd68b6910c2aa23409cb029644c8104017da..b8e12a48751bf3671cc607e66ec2875465c1a9b4 100644
--- a/components/safe_browsing/csd.proto
+++ b/components/safe_browsing/csd.proto
@@ -247,6 +247,19 @@ message LoginReputationClientResponse {
// The pattern will always match the page_url of the request, and will be
// a substring of page_url.
optional string cache_expression = 3;
+
+ // If set true, we match target URL with cache expression up to both of their
+ // last /'s.
+ //
+ // Examples:
+ // If set true, a cache_expression "foo.com/bar" will match
+ // "foo.com/bar",
+ // "foo.com/bar/bar.cgi",
+ // "foo.com/bar/login.html?param=val",
+ // but will NOT match
+ // "foo.com/abc/",
+ // "foo.com/bar/abc/edf.cgi"
vakh (use Gerrit instead) 2017/03/20 18:36:00 Can you also make it explicit that it won't match
Jialiu Lin 2017/03/20 19:05:54 Sure. Done.
+ optional bool cache_expression_exact_match = 4;
}
message ClientMalwareResponse {
« no previous file with comments | « components/content_settings/core/common/content_settings_types.h ('k') | components/safe_browsing/password_protection/BUILD.gn » ('j') | components/safe_browsing/password_protection/password_protection_service.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698