PasswordProtectionService verdict cache management

components/content_settings/core/browser/website_settings_registry.cc

Index: components/content_settings/core/browser/website_settings_registry.cc
diff --git a/components/content_settings/core/browser/website_settings_registry.cc b/components/content_settings/core/browser/website_settings_registry.cc
index 966d49626f8e45f64cadc9a57d2965a87e9a0828..1cfb54413831fd52855e2ad9e0294ac255e1b523 100644
--- a/components/content_settings/core/browser/website_settings_registry.cc
+++ b/components/content_settings/core/browser/website_settings_registry.cc
@@ -160,6 +160,11 @@ void WebsiteSettingsRegistry::Init() {
            WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE,
            DESKTOP | PLATFORM_ANDROID,
            WebsiteSettingsInfo::INHERIT_IN_INCOGNITO);
+  Register(
+      CONTENT_SETTINGS_TYPE_PASSWORD_PROTECTION, "password-protection", nullptr,
+      WebsiteSettingsInfo::UNSYNCABLE, WebsiteSettingsInfo::NOT_LOSSY,
+      WebsiteSettingsInfo::REQUESTING_ORIGIN_ONLY_SCOPE,

[Nathan Parker, 2017/03/16 21:27:11]

Can we have it cache by hostname rather than origin?  The ping and verdict
aren't ambivalent to scheme and port.  So if I visit a site w/ HTTPS and then
with HTTP, it MIGHT be better to reuse the verdict and not rewarn. Lemme know
your thoughts.

[Jialiu Lin, 2017/03/18 23:46:31]

I discussed this with Weining. "http vs. https is clearly a signal, so, it is
possible that they might result in different result."
Let's cache verdict by origin then. 

[Nathan Parker, 2017/03/20 15:55:35]

ok, though to be clear, the whitelist ignores scheme already. Do we know which
way Weining compared history URLs when estimating ping rates? 
 

[Jialiu Lin, 2017/03/20 18:02:39]

Yes, whitelist ignores scheme. I believe he estimated ping rates based on
site-chunk only. So we will probably end up with a ping rate higher than his
estimation (but x2 at most).   

+      DESKTOP | PLATFORM_ANDROID, WebsiteSettingsInfo::INHERIT_IN_INCOGNITO);
 }
 
 }  // namespace content_settings