components/safe_browsing/password_protection/DEPS - Issue 2747313002: PasswordProtectionService verdict cache management

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: components/safe_browsing/password_protection/DEPS

Issue 2747313002: PasswordProtectionService verdict cache management (Closed)

Patch Set: comments addressed partially Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "-content",	2 "-content",

	3 "+components/content_settings/core/browser",

	4 "+components/history/core/browser",

	5 "+components/safe_browsing/csd.pb.h",

3 "+components/safe_browsing_db",	6 "+components/safe_browsing_db",

	7 "+components/sync_preferences",
	battre 2017/03/17 09:32:43 Is this used anywhere? Is this used anywhere? Jialiu Lin 2017/03/18 23:46:32 Yes, components/sync_preferences/testing_pref_serv Show quoted text On 2017/03/17 09:32:43, battre wrote: > Is this used anywhere? Yes, components/sync_preferences/testing_pref_service_syncable.h is used in password_protection_service_unittest Let me narrow the scope to "+components/symc_preferences/testing_pref_service_syncable.h"
4 "+content/public/browser",	8 "+content/public/browser",

5 "+content/public/test",	9 "+content/public/test",

6 ]	10 ]

7	11

OLD	NEW