Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4800)

Unified Diff: chrome/browser/devtools/devtools_sanity_browsertest.cc

Issue 2747293006: Disable flaky DevToolsBeforeUnloadTest.TestUndockedDevToolsApplicationClose on Windows. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/devtools_sanity_browsertest.cc
diff --git a/chrome/browser/devtools/devtools_sanity_browsertest.cc b/chrome/browser/devtools/devtools_sanity_browsertest.cc
index 840f30a3152e78775bce2253f3cbcd19a06eb81c..8a70c2b6f1d0ce62be4cf1f4ec0ba9a977eb161a 100644
--- a/chrome/browser/devtools/devtools_sanity_browsertest.cc
+++ b/chrome/browser/devtools/devtools_sanity_browsertest.cc
@@ -729,7 +729,15 @@ IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
// Tests that BeforeUnload event gets called on undocked devtools if
// we try to close them.
-IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest, TestUndockedDevToolsClose) {
+// Flaky on Windows. http://crbug.com/702171
+#if defined(OS_WIN)
+#define MAYBE_TestUndockedDevToolsClose DISABLED_TestUndockedDevToolsClose
+#else
+#define MAYBE_TestUndockedDevToolsClose TestUndockedDevToolsClose
+#endif
+
+IN_PROC_BROWSER_TEST_F(DevToolsBeforeUnloadTest,
+ MAYBE_TestUndockedDevToolsClose) {
RunBeforeUnloadSanityTest(false, base::Bind(
&DevToolsBeforeUnloadTest::CloseDevToolsWindowAsync,
base::Unretained(this)), false);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698