Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Side by Side Diff: third_party/WebKit/Source/core/loader/FrameFetchContext.h

Issue 2747203002: Make prepareRequest() a separate callback of FetchContext (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 63 matching lines...) Expand 10 before | Expand all | Expand 10 after
74 74
75 void addAdditionalRequestHeaders(ResourceRequest&, 75 void addAdditionalRequestHeaders(ResourceRequest&,
76 FetchResourceType) override; 76 FetchResourceType) override;
77 WebCachePolicy resourceRequestCachePolicy( 77 WebCachePolicy resourceRequestCachePolicy(
78 ResourceRequest&, 78 ResourceRequest&,
79 Resource::Type, 79 Resource::Type,
80 FetchRequest::DeferOption) const override; 80 FetchRequest::DeferOption) const override;
81 void dispatchDidChangeResourcePriority(unsigned long identifier, 81 void dispatchDidChangeResourcePriority(unsigned long identifier,
82 ResourceLoadPriority, 82 ResourceLoadPriority,
83 int intraPriorityValue) override; 83 int intraPriorityValue) override;
84 void prepareRequest(ResourceRequest&, RedirectType) override;
84 void dispatchWillSendRequest( 85 void dispatchWillSendRequest(
85 unsigned long identifier, 86 unsigned long identifier,
86 ResourceRequest&, 87 ResourceRequest&,
87 const ResourceResponse& redirectResponse, 88 const ResourceResponse& redirectResponse,
88 const FetchInitiatorInfo& = FetchInitiatorInfo()) override; 89 const FetchInitiatorInfo& = FetchInitiatorInfo()) override;
89 void dispatchDidLoadResourceFromMemoryCache( 90 void dispatchDidLoadResourceFromMemoryCache(
90 unsigned long identifier, 91 unsigned long identifier,
91 Resource*, 92 Resource*,
92 WebURLRequest::FrameType, 93 WebURLRequest::FrameType,
93 WebURLRequest::RequestContext) override; 94 WebURLRequest::RequestContext) override;
(...skipping 13 matching lines...) Expand all
107 void dispatchDidFinishLoading(unsigned long identifier, 108 void dispatchDidFinishLoading(unsigned long identifier,
108 double finishTime, 109 double finishTime,
109 int64_t encodedDataLength, 110 int64_t encodedDataLength,
110 int64_t decodedBodyLength) override; 111 int64_t decodedBodyLength) override;
111 void dispatchDidFail(unsigned long identifier, 112 void dispatchDidFail(unsigned long identifier,
112 const ResourceError&, 113 const ResourceError&,
113 int64_t encodedDataLength, 114 int64_t encodedDataLength,
114 bool isInternalRequest) override; 115 bool isInternalRequest) override;
115 116
116 bool shouldLoadNewResource(Resource::Type) const override; 117 bool shouldLoadNewResource(Resource::Type) const override;
117 void willStartLoadingResource(unsigned long identifier, 118 void recordLoadingActivity(unsigned long identifier,
118 ResourceRequest&, 119 const ResourceRequest&,
119 Resource::Type, 120 Resource::Type,
120 const AtomicString& fetchInitiatorName, 121 const AtomicString& fetchInitiatorName) override;
121 V8ActivityLoggingPolicy) override;
122 void didLoadResource(Resource*) override; 122 void didLoadResource(Resource*) override;
123 123
124 void addResourceTiming(const ResourceTimingInfo&) override; 124 void addResourceTiming(const ResourceTimingInfo&) override;
125 bool allowImage(bool imagesEnabled, const KURL&) const override; 125 bool allowImage(bool imagesEnabled, const KURL&) const override;
126 ResourceRequestBlockedReason canRequest( 126 ResourceRequestBlockedReason canRequest(
127 Resource::Type, 127 Resource::Type,
128 const ResourceRequest&, 128 const ResourceRequest&,
129 const KURL&, 129 const KURL&,
130 const ResourceLoaderOptions&, 130 const ResourceLoaderOptions&,
131 SecurityViolationReportingPolicy, 131 SecurityViolationReportingPolicy,
(...skipping 55 matching lines...) Expand 10 before | Expand all | Expand 10 after
187 void printAccessDeniedMessage(const KURL&) const; 187 void printAccessDeniedMessage(const KURL&) const;
188 ResourceRequestBlockedReason canRequestInternal( 188 ResourceRequestBlockedReason canRequestInternal(
189 Resource::Type, 189 Resource::Type,
190 const ResourceRequest&, 190 const ResourceRequest&,
191 const KURL&, 191 const KURL&,
192 const ResourceLoaderOptions&, 192 const ResourceLoaderOptions&,
193 SecurityViolationReportingPolicy, 193 SecurityViolationReportingPolicy,
194 FetchRequest::OriginRestriction, 194 FetchRequest::OriginRestriction,
195 ResourceRequest::RedirectStatus) const; 195 ResourceRequest::RedirectStatus) const;
196 196
197 void prepareRequest(ResourceRequest&);
198
199 void dispatchDidReceiveResponseInternal(unsigned long identifier, 197 void dispatchDidReceiveResponseInternal(unsigned long identifier,
200 const ResourceResponse&, 198 const ResourceResponse&,
201 WebURLRequest::FrameType, 199 WebURLRequest::FrameType,
202 WebURLRequest::RequestContext, 200 WebURLRequest::RequestContext,
203 Resource*, 201 Resource*,
204 LinkLoader::CanLoadResources); 202 LinkLoader::CanLoadResources);
205 203
206 void addCSPHeaderIfNecessary(Resource::Type, ResourceRequest&); 204 void addCSPHeaderIfNecessary(Resource::Type, ResourceRequest&);
207 205
208 // FIXME: Oilpan: Ideally this should just be a traced Member but that will 206 // FIXME: Oilpan: Ideally this should just be a traced Member but that will
209 // currently leak because ComputedStyle and its data are not on the heap. 207 // currently leak because ComputedStyle and its data are not on the heap.
210 // See crbug.com/383860 for details. 208 // See crbug.com/383860 for details.
211 WeakMember<Document> m_document; 209 WeakMember<Document> m_document;
212 Member<DocumentLoader> m_documentLoader; 210 Member<DocumentLoader> m_documentLoader;
213 }; 211 };
214 212
215 } // namespace blink 213 } // namespace blink
216 214
217 #endif 215 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/loader/FrameFetchContext.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698