third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp - Issue 2747193002: Fix instances of clang -Wbitfield-enum-conversion in Blink

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp

Issue 2747193002: Fix instances of clang -Wbitfield-enum-conversion in Blink (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h ('K') | « third_party/WebKit/Source/core/layout/ng/ng_constraint_space_builder.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp

diff --git a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp

index a6a9a698d8d03dcd90e0e31e0df5405243469220..8de868507a3e0524f1431f046f359bc6b016922d 100644

--- a/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp

+++ b/third_party/WebKit/Source/core/svg/properties/SVGAnimatedProperty.cpp

@@ -40,7 +40,7 @@ SVGAnimatedPropertyBase::SVGAnimatedPropertyBase(

const QualifiedName& attributeName,

CSSPropertyID cssPropertyId)

: m_type(type),

- m_cssPropertyId(cssPropertyId),

+ m_cssPropertyId(static_cast<unsigned>(cssPropertyId)),

Nico 2017/03/14 17:16:47 add comment why a) cast is here b) why this is saf

m_contextElement(contextElement),

m_attributeName(attributeName) {

DCHECK(m_contextElement);