third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h - Issue 2747163002: Bindings: Manage multiple DOMWrapperWorlds for worklets (2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

Issue 2747163002: Bindings: Manage multiple DOMWrapperWorlds for worklets (2) (Closed)

Patch Set: address review comments & may fix use-after-free bug in the test Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

index f1825983d3cfbdd350d95092a58f9afe7fc8f833..03d903065415b8d46156e68f9e01e0d5b8b46332 100644

--- a/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

+++ b/third_party/WebKit/Source/bindings/core/v8/DOMDataStore.h

@@ -156,7 +156,7 @@ class DOMDataStore {

// be in the main world).

static bool canUseMainWorldWrapper() {

return !WTF::mayNotBeMainThread() &&

- !DOMWrapperWorld::nonMainWorldsInMainThread();

+ !DOMWrapperWorld::nonMainWorldsExistInMainThread();

}

static bool holderContainsWrapper(v8::Local<v8::Object> holder,