Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2747113004: Run dartfmt on kernel package (Closed)

Created:
3 years, 9 months ago by Jacob
Modified:
3 years, 9 months ago
Reviewers:
asgerf
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+118 lines, -129 lines) Patch
M pkg/kernel/lib/target/vm.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M pkg/kernel/lib/transformations/closure/context.dart View 1 chunk +3 lines, -4 lines 0 comments Download
M pkg/kernel/lib/transformations/insert_covariance_checks.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/kernel/test/reify/suite.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/closures/capture_closure_parameter.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/kernel/testcases/closures/closure_in_initializer_closure.dart View 1 chunk +9 lines, -8 lines 0 comments Download
M pkg/kernel/testcases/closures/for_variable_capture_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/testcases/closures/type_variables.dart View 2 chunks +6 lines, -5 lines 0 comments Download
M pkg/kernel/testcases/input/DeltaBlue.dart View 19 chunks +33 lines, -50 lines 0 comments Download
M pkg/kernel/testcases/input/argument.dart View 1 chunk +6 lines, -12 lines 0 comments Download
M pkg/kernel/testcases/input/call.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/kernel/testcases/input/closure.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/testcases/input/escape.dart View 1 chunk +3 lines, -1 line 0 comments Download
M pkg/kernel/testcases/input/micro.dart View 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/kernel/testcases/input/optional.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/testcases/input/override.dart View 1 chunk +1 line, -0 lines 0 comments Download
M pkg/kernel/testcases/input/prefer_baseclass.dart View 1 chunk +3 lines, -0 lines 0 comments Download
M pkg/kernel/testcases/input/redirecting_factory.dart View 1 chunk +21 lines, -25 lines 0 comments Download
M pkg/kernel/testcases/input/static_setter.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/kernel/testcases/input/store_load.dart View 1 chunk +2 lines, -0 lines 0 comments Download
M pkg/kernel/testcases/input/uninitialized_fields.dart View 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/kernel/testcases/input/void-methods.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/kernel/testcases/reify/native_types_test.dart View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Jacob
3 years, 9 months ago (2017-03-16 03:51:17 UTC) #2
Jacob
ping?
3 years, 9 months ago (2017-03-16 23:17:43 UTC) #3
asgerf
LGTM. (I was OOO yesterday)
3 years, 9 months ago (2017-03-17 10:08:57 UTC) #4
Jacob
3 years, 9 months ago (2017-03-17 15:22:22 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
d1fa3c67af550e98506f820c108411c8778aca32 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698