Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(369)

Issue 27471003: Partially annotate V8 for MemorySanitizer. (Closed)

Created:
7 years, 2 months ago by eugenis
Modified:
7 years, 2 months ago
Reviewers:
danno, Evgeniy Stepanov
CC:
v8-dev
Visibility:
Public.

Description

Partially annotate V8 for MemorySanitizer. This is a part of https://codereview.chromium.org/26006004/. These changes are enough to run most apps that embed V8 (by additionally ignoring all memory accesses from V8), but don't help testing V8 itself in any way. R=danno@chromium.org Committed: http://code.google.com/p/v8/source/detail?r=17331

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+51 lines, -0 lines) Patch
A src/msan.h View 1 chunk +49 lines, -0 lines 0 comments Download
M src/spaces.cc View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
eugenis
7 years, 2 months ago (2013-10-16 13:40:33 UTC) #1
Evgeniy Stepanov
ping
7 years, 2 months ago (2013-10-21 07:58:52 UTC) #2
danno
This looks OK fundamentally, but one question: this only works with the ARM simulator, right?
7 years, 2 months ago (2013-10-21 09:31:34 UTC) #3
Evgeniy Stepanov
On 2013/10/21 09:31:34, danno wrote: > This looks OK fundamentally, but one question: this only ...
7 years, 2 months ago (2013-10-21 09:59:33 UTC) #4
danno
lgtm
7 years, 2 months ago (2013-10-21 11:43:34 UTC) #5
Evgeniy Stepanov
On 2013/10/21 11:43:34, danno wrote: > lgtm Thanks. This commit checkbox does not seem to ...
7 years, 2 months ago (2013-10-21 12:29:14 UTC) #6
danno
7 years, 2 months ago (2013-10-23 08:39:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 manually as r17331 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698