chrome/test/mini_installer/variable_expander.py - Issue 2747023002: Cleanup machine based on the state in configuration file for mini installer test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/mini_installer/variable_expander.py

Issue 2747023002: Cleanup machine based on the state in configuration file for mini installer test.

Patch Set: refactor to use visitor pattern Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/mini_installer/variable_expander.py

diff --git a/chrome/test/mini_installer/variable_expander.py b/chrome/test/mini_installer/variable_expander.py

index 551bf61b21b445e55f8fadea0ee347eab5ffb6f7..807c6f99acdb14a3beb2dec7a773807c86e5f789 100644

--- a/chrome/test/mini_installer/variable_expander.py

+++ b/chrome/test/mini_installer/variable_expander.py

@@ -164,7 +164,7 @@ class VariableExpander:

mini_installer_product_name)

- def Expand(self, str):

+ def Expand(self, input_string):

"""Expands variables in the given string.

This method resolves only variables defined in the constructor. It does not

@@ -173,9 +173,9 @@ class VariableExpander:

be raised.

Args:

- str: A string.

+ input_string: A string with variables.

Returns:

A new string created by replacing variables with their values.

"""

- return string.Template(str).substitute(self._variable_mapping)

+ return string.Template(input_string).substitute(self._variable_mapping)

« no previous file with comments | « chrome/test/mini_installer/test_installer.py ('k') | chrome/test/mini_installer/verifier.py » ('j') | no next file with comments »