Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(684)

Unified Diff: chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc

Issue 2746873004: Move ChromeOS login media access logic into a MediaAccessHandler (Closed)
Patch Set: Move SAML access logic into MediaAccessHandler Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
diff --git a/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc b/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
index 34c419f6009f3c0dd2f0b80236432eb80e80c170..5a21705a71117e1d098419a3843dc9e701b7bc24 100644
--- a/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
+++ b/chrome/browser/media/webrtc/media_capture_devices_dispatcher.cc
@@ -38,6 +38,7 @@
#include "ash/shell.h"
#include "chrome/browser/media/public_session_media_access_handler.h"
#include "chrome/browser/media/public_session_tab_capture_access_handler.h"
+#include "chrome/browser/media/saml_media_access_handler.h"
#endif // defined(OS_CHROMEOS)
#if BUILDFLAG(ENABLE_EXTENSIONS)
@@ -68,6 +69,12 @@ const content::MediaStreamDevice* FindDeviceWithId(
return NULL;
}
+content::WebContents* WebContentsFromIds(int render_process_id,
+ int render_frame_id) {
+ return content::WebContents::FromRenderFrameHost(
+ content::RenderFrameHost::FromID(render_process_id, render_frame_id));
+}
+
#if BUILDFLAG(ENABLE_EXTENSIONS)
inline CaptureAccessHandlerBase* ToCaptureAccessHandlerBase(
MediaAccessHandler* handler) {
@@ -87,6 +94,7 @@ MediaCaptureDevicesDispatcher::MediaCaptureDevicesDispatcher()
#if BUILDFLAG(ENABLE_EXTENSIONS)
#if defined(OS_CHROMEOS)
+ media_access_handlers_.push_back(new SamlMediaAccessHandler());
// Wrapper around ExtensionMediaAccessHandler used in Public Sessions.
media_access_handlers_.push_back(new PublicSessionMediaAccessHandler());
#else
@@ -159,8 +167,10 @@ void MediaCaptureDevicesDispatcher::ProcessMediaAccessRequest(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
for (MediaAccessHandler* handler : media_access_handlers_) {
- if (handler->SupportsStreamType(request.video_type, extension) ||
- handler->SupportsStreamType(request.audio_type, extension)) {
+ if (handler->SupportsStreamType(web_contents, request.video_type,
+ extension) ||
+ handler->SupportsStreamType(web_contents, request.audio_type,
+ extension)) {
handler->HandleRequest(web_contents, request, callback, extension);
return;
}
@@ -185,7 +195,7 @@ bool MediaCaptureDevicesDispatcher::CheckMediaAccessPermission(
const extensions::Extension* extension) {
DCHECK_CURRENTLY_ON(BrowserThread::UI);
for (MediaAccessHandler* handler : media_access_handlers_) {
- if (handler->SupportsStreamType(type, extension)) {
+ if (handler->SupportsStreamType(web_contents, type, extension)) {
return handler->CheckMediaAccessPermission(web_contents, security_origin,
type, extension);
}
@@ -355,8 +365,11 @@ void MediaCaptureDevicesDispatcher::UpdateMediaRequestStateOnUIThread(
const GURL& security_origin,
content::MediaStreamType stream_type,
content::MediaRequestState state) {
+ DCHECK_CURRENTLY_ON(BrowserThread::UI);
for (MediaAccessHandler* handler : media_access_handlers_) {
- if (handler->SupportsStreamType(stream_type, nullptr)) {
+ if (handler->SupportsStreamType(
+ WebContentsFromIds(render_process_id, render_frame_id), stream_type,
+ nullptr)) {
handler->UpdateMediaRequestState(render_process_id, render_frame_id,
page_request_id, stream_type, state);
break;
@@ -394,10 +407,12 @@ bool MediaCaptureDevicesDispatcher::IsInsecureCapturingInProgress(
DCHECK_CURRENTLY_ON(BrowserThread::UI);
#if BUILDFLAG(ENABLE_EXTENSIONS)
for (MediaAccessHandler* handler : media_access_handlers_) {
- if (handler->SupportsStreamType(content::MEDIA_DESKTOP_VIDEO_CAPTURE,
- nullptr) ||
- handler->SupportsStreamType(content::MEDIA_TAB_VIDEO_CAPTURE,
- nullptr)) {
+ if (handler->SupportsStreamType(
+ WebContentsFromIds(render_process_id, render_frame_id),
+ content::MEDIA_DESKTOP_VIDEO_CAPTURE, nullptr) ||
+ handler->SupportsStreamType(
+ WebContentsFromIds(render_process_id, render_frame_id),
+ content::MEDIA_TAB_VIDEO_CAPTURE, nullptr)) {
if (ToCaptureAccessHandlerBase(handler)->IsInsecureCapturingInProgress(
render_process_id, render_frame_id))
return true;
@@ -448,7 +463,9 @@ void MediaCaptureDevicesDispatcher::UpdateCapturingLinkSecured(
#if BUILDFLAG(ENABLE_EXTENSIONS)
for (MediaAccessHandler* handler : media_access_handlers_) {
- if (handler->SupportsStreamType(stream_type, nullptr)) {
+ if (handler->SupportsStreamType(
+ WebContentsFromIds(render_process_id, render_frame_id), stream_type,
+ nullptr)) {
ToCaptureAccessHandlerBase(handler)->UpdateCapturingLinkSecured(
render_process_id, render_frame_id, page_request_id, is_secure);
break;

Powered by Google App Engine
This is Rietveld 408576698