Move ChromeOS login media access logic into a MediaAccessHandler

chrome/browser/chromeos/login/webview_login_browsertest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "base/macros.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/chromeos/login/test/oobe_base_test.h"
 #include "chrome/browser/chromeos/login/ui/webui_login_display.h"
 #include "chromeos/chromeos_switches.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
+#include "media/base/media_switches.h"
 
 namespace chromeos {
 
 class WebviewLoginTest : public OobeBaseTest {
  public:
   WebviewLoginTest() {}
   ~WebviewLoginTest() override {}
 
   void SetUpCommandLine(base::CommandLine* command_line) override {
     command_line->AppendSwitch(switches::kOobeSkipPostLogin);
+    command_line->AppendSwitch(::switches::kUseFakeDeviceForMediaStream);
     OobeBaseTest::SetUpCommandLine(command_line);
   }
 
  protected:
   void ClickNext() {
     ExecuteJsInSigninFrame("document.getElementById('nextButton').click();");
   }
 
   void ExpectIdentifierPage() {
     // First page: no back button, no close button, refresh button, #identifier
@@ skipping 92 matching lines @@
   JsExpect(frame_url + ".search('flow=nosignup') != -1");
 }
 
 IN_PROC_BROWSER_TEST_F(WebviewLoginTest, EmailPrefill) {
   WaitForGaiaPageLoad();
   JS().ExecuteAsync("Oobe.showSigninUI('user@example.com')");
   WaitForGaiaPageReload();
   EXPECT_EQ(fake_gaia_->prefilled_email(), "user@example.com");
 }
 
+// Tests that requesting webcam access from the login screen works correctly.
+// This is needed for taking profile pictures.
+IN_PROC_BROWSER_TEST_F(WebviewLoginTest, RequestCamera) {

[achuithb, 2017/04/05 00:55:36]

Thanks for adding this.

+  WaitForGaiaPageLoad();
+
+  // Video devices should be allowed from the login screen.
+  content::WebContents* web_contents = GetLoginUI()->GetWebContents();
+  bool getUserMediaSuccess = false;
+  ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+      web_contents->GetMainFrame(),
+      "navigator.getUserMedia("
+      "    {video: true},"
+      "    function() { window.domAutomationController.send(true); },"
+      "    function() { window.domAutomationController.send(false); });",
+      &getUserMediaSuccess));
+  ASSERT_TRUE(getUserMediaSuccess);

[emaxx, 2017/04/06 02:41:47]

nit: Replace with EXPECT_TRUE here and in other places? As the usual approach,
AFAIU, is to use ASSERT_* only when the subsequent checks will crash or
something.

[raymes, 2017/04/10 00:16:48]

Done.

+
+  // Audio devices should be denied from the login screen.
+  ASSERT_TRUE(content::ExecuteScriptAndExtractBool(
+      web_contents->GetMainFrame(),
+      "navigator.getUserMedia("
+      "    {audio: true},"
+      "    function() { window.domAutomationController.send(true); },"
+      "    function() { window.domAutomationController.send(false); });",
+      &getUserMediaSuccess));
+  ASSERT_FALSE(getUserMediaSuccess);
+}
+
 }  // namespace chromeos