ui/views/accessibility/native_view_accessibility_stub.cc - Issue 2746813002: Hide AXPlatformNode on ChromeOS.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: ui/views/accessibility/native_view_accessibility_stub.cc

Issue 2746813002: Hide AXPlatformNode on ChromeOS. (Closed)

Patch Set: fix stub Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« ui/views/accessibility/native_view_accessibility_base.h ('K') | « ui/views/accessibility/native_view_accessibility_mac.mm ('k') | ui/views/accessibility/native_view_accessibility_unittest.cc » ('j') | ui/views/controls/tabbed_pane/tabbed_pane_unittest.cc » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #include "ui/views/accessibility/native_view_accessibility_base.h"

	6

	7 namespace views {

	8

	9 // static

	10 std::unique_ptr<NativeViewAccessibilityBase>

	11 NativeViewAccessibilityBase::Create(View* view) {

	12 return nullptr;
	tapted 2017/03/20 10:36:11 we could also return a dummy object here, but view we could also return a dummy object here, but view.cc has null checks whenever it accesses \|native_view_accessibility_\|, so this should be fine. An alternative is to provide the same "never returns null" guarantee that AXPlatformNode now has - that might neaten up some of the call sites in view.cc. (i.e. by implementing a concrete "stub" class that just returns null from GetNativeObject) dmazzoni 2017/03/20 15:44:06 Semantically this approach seems more clear than a Show quoted text On 2017/03/20 10:36:11, tapted wrote: > we could also return a dummy object here, but view.cc has null checks whenever > it accesses \|native_view_accessibility_\|, so this should be fine. > > An alternative is to provide the same "never returns null" guarantee that > AXPlatformNode now has - that might neaten up some of the call sites in view.cc. > > (i.e. by implementing a concrete "stub" class that just returns null from > GetNativeObject) Semantically this approach seems more clear than a stub class - it makes more sense to say that we don't have or need an implementation on some platforms rather than saying we're going to create an instance for every view that does nothing.
	13 }

	14

	15 } // namespace views

OLD	NEW