Hide AXPlatformNode on ChromeOS.

ui/views/accessibility/native_view_accessibility_base.h

+// Copyright (c) 2013 The Chromium Authors. All rights reserved.

[dmazzoni, 2017/03/20 15:44:06]

2017

[tapted, 2017/03/21 02:27:49]

Done (although this is now closer to a "fork" of native_view_accessibility.h but
probably different enough that it deserves a new header).

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_BASE_H_
+#define UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_BASE_H_
+
+#include <memory>
+
+#include "base/macros.h"
+#include "ui/accessibility/ax_enums.h"
+#include "ui/gfx/native_widget_types.h"
+#include "ui/views/views_export.h"
+
+namespace views {
+
+class View;
+
+// Abstract base for that allows native platform accessibility toolkits to
+// interface with a View.
+class VIEWS_EXPORT NativeViewAccessibilityBase {

[dmazzoni, 2017/03/20 15:44:06]

This naming pattern, while not unintuitive, seems inconsistent with the pattern
we're using
elsewhere in the code:

RenderWidgetHostView (abstract public interface)
  RenderWidgetHostViewBase (cross-platform base class with shared code)
    RenderWidgetHostViewMac (Mac-specific subclass)
    RenderWidgetHostViewAura (Aura-specific subclass)

I did the same with AXPlatformNode:

AXPlatformNode (public interface)
  AXPlatformNodeBase (cross-platform base class with shared code)
    AXPlatformNodeMac (Mac-specific subclass)
    AXPlatformNodeWin (Win-specific subclass)

So I'd prefer we don't flip "Base" to mean the abstract interface.

I'd be happy with any of these

NativeViewAccessibilityInterface -> NativeViewAccessibility
AbstractNativeViewAccessibility -> NativeViewAccessibility
NativeViewAccessibility -> NativeViewAccessibilityBase

[tapted, 2017/03/21 02:27:49]

Done.

I was tempted by NativeViewAccessibilityInterface to keep the diff a little more
sane, but I think NativeViewAccessibility -> NativeViewAccessibilityBase makes
the most sense for consistency.

+ public:
+  static std::unique_ptr<NativeViewAccessibilityBase> Create(View* view);
+
+  virtual ~NativeViewAccessibilityBase() {}
+
+  virtual gfx::NativeViewAccessible GetNativeObject() = 0;
+  virtual void NotifyAccessibilityEvent(ui::AXEvent event_type) = 0;
+
+ protected:
+  NativeViewAccessibilityBase() {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(NativeViewAccessibilityBase);
+};
+
+}  // namespace views
+
+#endif  // UI_VIEWS_ACCESSIBILITY_NATIVE_VIEW_ACCESSIBILITY_BASE_H_