Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(129)

Issue 2746793004: Added cgroup-awareness to Chromium (second draft)

Created:
3 years, 9 months ago by mosajjal
Modified:
3 years, 9 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews, vmpstr+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

this one compiles we can now close #2745473002 BUG=620409

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -1 line) Patch
M base/process/process_metrics_linux.cc View 2 chunks +62 lines, -1 line 0 comments Download

Messages

Total messages: 3 (2 generated)
Lei Zhang
3 years, 9 months ago (2017-03-15 01:20:41 UTC) #3
- You don't have to upload a new Change List. You could have added a new patch
set to https://codereview.chromium.org/2745473002/
- The description field for this CL is what ends up getting written into the git
commit. It probably should not say "this one compiles"
- As mentioned on https://codereview.chromium.org/2745473002/, the code
formatting needs to be better. Just


as

in the real

   world you do not format
sentences like this.

You can always run "git cl format" to let the computer do it for you.

When the code formatting looks better, I can take a look without straining my
eyes.

Powered by Google App Engine
This is Rietveld 408576698