third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp - Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)

Patch Set: Rebase and address shimazu's comment #33 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

diff --git a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

index c7e8b5b33844e27bd80aced8b8bb71899f7eec8f..04698f8e713a8f844cc2d37aff31fd71eae1b41d 100644

--- a/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

+++ b/third_party/WebKit/Source/web/ServiceWorkerGlobalScopeProxy.cpp

@@ -375,8 +375,8 @@ void ServiceWorkerGlobalScopeProxy::DispatchForeignFetchEvent(

void ServiceWorkerGlobalScopeProxy::DispatchInstallEvent(int event_id) {

WaitUntilObserver* observer = WaitUntilObserver::Create(

WorkerGlobalScope(), WaitUntilObserver::kInstall, event_id);

- Event* event = InstallEvent::Create(EventTypeNames::install,

- ExtendableEventInit(), observer);

+ Event* event = InstallEvent::Create(

+ EventTypeNames::install, ExtendableEventInit(), event_id, observer);

WorkerGlobalScope()->DispatchExtendableEvent(event, observer);

}