Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: content/browser/service_worker/service_worker_job_unittest.cc

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)
Patch Set: Rebase and address shimazu's comment #33 Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_job_unittest.cc
diff --git a/content/browser/service_worker/service_worker_job_unittest.cc b/content/browser/service_worker/service_worker_job_unittest.cc
index 5c0d7ea230460e118a1db71b5f4813c7c10dcc49..4d2caca7f56794bb5a164fb59db3eda022313f03 100644
--- a/content/browser/service_worker/service_worker_job_unittest.cc
+++ b/content/browser/service_worker/service_worker_job_unittest.cc
@@ -295,8 +295,8 @@ TEST_F(ServiceWorkerJobTest, Register) {
GURL("http://www.example.com/service_worker.js"));
ASSERT_NE(scoped_refptr<ServiceWorkerRegistration>(NULL), registration);
- EXPECT_TRUE(helper_->inner_ipc_sink()->GetUniqueMessageMatching(
- ServiceWorkerMsg_InstallEvent::ID));
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Install,
+ helper_->dispatched_events()->at(0));
}
// Make sure registrations are cleaned up when they are unregistered.
@@ -1471,13 +1471,14 @@ class EventCallbackHelper : public EmbeddedWorkerTestHelper {
install_event_result_(blink::kWebServiceWorkerEventResultCompleted),
activate_event_result_(blink::kWebServiceWorkerEventResultCompleted) {}
- void OnInstallEvent(int embedded_worker_id,
- int request_id) override {
+ void OnInstallEvent(
+ const mojom::ServiceWorkerEventDispatcher::DispatchInstallEventCallback&
+ callback) override {
if (!install_callback_.is_null())
install_callback_.Run();
- SimulateSend(new ServiceWorkerHostMsg_InstallEventFinished(
- embedded_worker_id, request_id, install_event_result_,
- has_fetch_handler_, base::Time::Now()));
+ dispatched_events()->push_back(Event::Install);
+ callback.Run(EventResultToStatus(install_event_result_), has_fetch_handler_,
+ base::Time::Now());
}
void OnActivateEvent(

Powered by Google App Engine
This is Rietveld 408576698