[ServiceWorker] Mojofy InstallEvent of Service Worker

content/browser/service_worker/service_worker_version.h

Index: content/browser/service_worker/service_worker_version.h
diff --git a/content/browser/service_worker/service_worker_version.h b/content/browser/service_worker/service_worker_version.h
index 5ae425b0575b8dff81a047f865ae9bb8c848605e..10d1de353b54fa3f418c778db22544f37a4e42cd 100644
--- a/content/browser/service_worker/service_worker_version.h
+++ b/content/browser/service_worker/service_worker_version.h
@@ -272,6 +272,9 @@ class CONTENT_EXPORT ServiceWorkerVersion
                      bool was_handled,
                      base::Time dispatch_event_time);
 
+  void RegisterForeignFetchScopes(const std::vector<GURL>& sub_scopes,

[shimazu, 2017/04/05 05:01:27]

Could you move this after RegisterRequestCallback and add a comment like "//
Implements mojom::ServiceWorkerInstallEventMethods"?

[xiaofengzhang, 2017/04/18 06:46:17]

Nice, thanks. But this function(RegisterForeignFetchScopes) is not the
implementation of mojom::ServiceWorkerInstallEventMethods". I just change the
name, and in my original patch, it was called in
ServiceWorkerRegisterJob::Register.

+                                  const std::vector<url::Origin>& origins);
+
   // Finishes an external request that was started by StartExternalRequest().
   // Returns false if there was an error finishing the request: e.g. the request
   // was not found or the worker already terminated.
@@ -687,9 +690,6 @@ class CONTENT_EXPORT ServiceWorkerVersion
   void OnFocusClientFinished(int request_id,
                              const ServiceWorkerClientInfo& client_info);
 
-  void OnRegisterForeignFetchScopes(const std::vector<GURL>& sub_scopes,
-                                    const std::vector<url::Origin>& origins);
-
   void DidEnsureLiveRegistrationForStartWorker(
       ServiceWorkerMetrics::EventType purpose,
       Status prestart_status,