Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2024)

Unified Diff: content/renderer/service_worker/service_worker_context_client.h

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)
Patch Set: Just delete a useless line Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/service_worker/service_worker_context_client.h
diff --git a/content/renderer/service_worker/service_worker_context_client.h b/content/renderer/service_worker/service_worker_context_client.h
index 835f079079a489cbdbd0cfbad009f9673ad8d740..4facb49d5caf8967076f49a0225c3de507bdb684 100644
--- a/content/renderer/service_worker/service_worker_context_client.h
+++ b/content/renderer/service_worker/service_worker_context_client.h
@@ -156,7 +156,7 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
int request_id,
blink::WebServiceWorkerEventResult result,
double dispatch_event_time) override;
- void DidHandleInstallEvent(int request_id,
+ void DidHandleInstallEvent(int event_id,
blink::WebServiceWorkerEventResult result,
double event_dispatch_time) override;
void RespondToFetchEventWithNoResponse(int fetch_event_id,
@@ -213,6 +213,7 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
void Claim(std::unique_ptr<blink::WebServiceWorkerClientsClaimCallbacks>
callbacks) override;
void RegisterForeignFetchScopes(
+ int install_event_id,
const blink::WebVector<blink::WebURL>& sub_scopes,
const blink::WebVector<blink::WebSecurityOrigin>& origins) override;
@@ -231,6 +232,9 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
const ServiceWorkerVersionAttributes& attrs);
// mojom::ServiceWorkerEventDispatcher
+ void DispatchInstallEvent(
+ mojom::ServiceWorkerInstallEventMethodsAssociatedPtrInfo client,
+ DispatchInstallEventCallback callback) override;
void DispatchActivateEvent(DispatchActivateEventCallback callback) override;
void DispatchBackgroundFetchAbortEvent(
const std::string& tag,
@@ -279,7 +283,6 @@ class ServiceWorkerContextClient : public blink::WebServiceWorkerContextClient,
DispatchPaymentRequestEventCallback callback) override;
void Ping(PingCallback callback) override;
- void OnInstallEvent(int request_id);
void OnNotificationClickEvent(
int request_id,
const std::string& notification_id,

Powered by Google App Engine
This is Rietveld 408576698