Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Unified Diff: content/browser/service_worker/service_worker_context_unittest.cc

Issue 2746783002: [ServiceWorker] Mojofy InstallEvent of Service Worker (Closed)
Patch Set: Just delete a useless line Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/service_worker/service_worker_context_unittest.cc
diff --git a/content/browser/service_worker/service_worker_context_unittest.cc b/content/browser/service_worker/service_worker_context_unittest.cc
index 03265cd90d99fc242fb4bc8d8c7c8d392b7782f2..15aac69ce9a40da25a5628414f8fe4fac515a570 100644
--- a/content/browser/service_worker/service_worker_context_unittest.cc
+++ b/content/browser/service_worker/service_worker_context_unittest.cc
@@ -85,11 +85,13 @@ class RejectInstallTestHelper : public EmbeddedWorkerTestHelper {
public:
RejectInstallTestHelper() : EmbeddedWorkerTestHelper(base::FilePath()) {}
- void OnInstallEvent(int embedded_worker_id,
- int request_id) override {
- SimulateSend(new ServiceWorkerHostMsg_InstallEventFinished(
- embedded_worker_id, request_id,
- blink::kWebServiceWorkerEventResultRejected, true, base::Time::Now()));
+ void OnInstallEvent(
+ mojom::ServiceWorkerInstallEventMethodsAssociatedPtrInfo client,
+ mojom::ServiceWorkerEventDispatcher::DispatchInstallEventCallback
+ callback) override {
+ dispatched_events()->push_back(Event::Install);
+ std::move(callback).Run(SERVICE_WORKER_ERROR_EVENT_WAITUNTIL_REJECTED,
+ true /* has_fetch_handler */, base::Time::Now());
}
};
@@ -217,15 +219,14 @@ TEST_F(ServiceWorkerContextTest, Register) {
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(called);
- EXPECT_EQ(1UL, helper_->ipc_sink()->message_count());
- ASSERT_EQ(1UL, helper_->dispatched_events()->size());
+ ASSERT_EQ(2UL, helper_->dispatched_events()->size());
ASSERT_EQ(2UL, client->events().size());
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StartWorker,
client->events()[0]);
- EXPECT_TRUE(helper_->inner_ipc_sink()->GetUniqueMessageMatching(
- ServiceWorkerMsg_InstallEvent::ID));
- EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Activate,
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Install,
helper_->dispatched_events()->at(0));
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Activate,
+ helper_->dispatched_events()->at(1));
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StopWorker,
client->events()[1]);
@@ -273,13 +274,12 @@ TEST_F(ServiceWorkerContextTest, Register_RejectInstall) {
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(called);
- EXPECT_EQ(1UL, helper_->ipc_sink()->message_count());
- EXPECT_EQ(0UL, helper_->dispatched_events()->size());
+ ASSERT_EQ(1UL, helper_->dispatched_events()->size());
ASSERT_EQ(2UL, client->events().size());
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StartWorker,
client->events()[0]);
- EXPECT_TRUE(helper_->inner_ipc_sink()->GetUniqueMessageMatching(
- ServiceWorkerMsg_InstallEvent::ID));
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Install,
+ helper_->dispatched_events()->at(0));
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StopWorker,
client->events()[1]);
@@ -324,15 +324,14 @@ TEST_F(ServiceWorkerContextTest, Register_RejectActivate) {
base::RunLoop().RunUntilIdle();
EXPECT_TRUE(called);
- EXPECT_EQ(1UL, helper_->ipc_sink()->message_count());
- ASSERT_EQ(1UL, helper_->dispatched_events()->size());
+ ASSERT_EQ(2UL, helper_->dispatched_events()->size());
ASSERT_EQ(2UL, client->events().size());
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StartWorker,
client->events()[0]);
- EXPECT_TRUE(helper_->inner_ipc_sink()->GetUniqueMessageMatching(
- ServiceWorkerMsg_InstallEvent::ID));
- EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Activate,
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Install,
helper_->dispatched_events()->at(0));
+ EXPECT_EQ(EmbeddedWorkerTestHelper::Event::Activate,
+ helper_->dispatched_events()->at(1));
EXPECT_EQ(RecordableEmbeddedWorkerInstanceClient::Message::StopWorker,
client->events()[1]);

Powered by Google App Engine
This is Rietveld 408576698