Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(670)

Unified Diff: src/inspector/v8-debugger.h

Issue 2746743002: [inspector] support setTimeout in Debugger.scheduleStepIntoAsync method (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/api.cc ('k') | src/inspector/v8-debugger.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/inspector/v8-debugger.h
diff --git a/src/inspector/v8-debugger.h b/src/inspector/v8-debugger.h
index 12d6ca385610bcd309ca99688376b9aba3a2f2a4..435bfaabb3f6c609bbcecde3d7f0df87daaa1fc5 100644
--- a/src/inspector/v8-debugger.h
+++ b/src/inspector/v8-debugger.h
@@ -10,6 +10,7 @@
#include "src/base/macros.h"
#include "src/debug/debug-interface.h"
#include "src/inspector/java-script-call-frame.h"
+#include "src/inspector/protocol/Debugger.h"
#include "src/inspector/protocol/Forward.h"
#include "src/inspector/protocol/Runtime.h"
#include "src/inspector/v8-debugger-script.h"
@@ -25,6 +26,8 @@ class V8InspectorImpl;
class V8StackTraceImpl;
using protocol::Response;
+using ScheduleStepIntoAsyncCallback =
+ protocol::Debugger::Backend::ScheduleStepIntoAsyncCallback;
class V8Debugger : public v8::debug::DebugDelegate {
public:
@@ -49,6 +52,9 @@ class V8Debugger : public v8::debug::DebugDelegate {
void stepIntoStatement(int targetContextGroupId);
void stepOverStatement(int targetContextGroupId);
void stepOutOfFunction(int targetContextGroupId);
+ void scheduleStepIntoAsync(
+ std::unique_ptr<ScheduleStepIntoAsyncCallback> callback,
+ int targetContextGroupId);
Response setScriptSource(
const String16& sourceID, v8::Local<v8::String> newSource, bool dryRun,
@@ -80,7 +86,6 @@ class V8Debugger : public v8::debug::DebugDelegate {
void asyncTaskScheduled(const StringView& taskName, void* task,
bool recurring);
- void asyncTaskScheduled(const String16& taskName, void* task, bool recurring);
void asyncTaskCanceled(void* task);
void asyncTaskStarted(void* task);
void asyncTaskFinished(void* task);
@@ -126,7 +131,18 @@ class V8Debugger : public v8::debug::DebugDelegate {
v8::MaybeLocal<v8::Value> generatorScopes(v8::Local<v8::Context>,
v8::Local<v8::Value>);
- void asyncTaskCreated(void* task, void* parentTask);
+ void asyncTaskCreatedForStack(void* task, void* parentTask);
+ void asyncTaskScheduledForStack(const String16& taskName, void* task,
+ bool recurring);
+ void asyncTaskCanceledForStack(void* task);
+ void asyncTaskStartedForStack(void* task);
+ void asyncTaskFinishedForStack(void* task);
+
+ void asyncTaskCandidateForStepping(void* task);
+ void asyncTaskStartedForStepping(void* task);
+ void asyncTaskFinishedForStepping(void* task);
+ void asyncTaskCanceledForStepping(void* task);
+
void registerAsyncTaskIfNeeded(void* task);
// v8::debug::DebugEventListener implementation.
@@ -147,10 +163,6 @@ class V8Debugger : public v8::debug::DebugDelegate {
const v8::debug::Location& end) override;
int currentContextGroupId();
- void handleAsyncTaskStepping(v8::Local<v8::Context> context,
- v8::debug::PromiseDebugActionType type,
- void* task, void* parentTask,
- bool createdByUser);
v8::Isolate* m_isolate;
V8InspectorImpl* m_inspector;
@@ -182,6 +194,9 @@ class V8Debugger : public v8::debug::DebugDelegate {
protocol::HashMap<void*, void*> m_firstNextTask;
void* m_taskWithScheduledBreak = nullptr;
+ std::unique_ptr<ScheduleStepIntoAsyncCallback> m_stepIntoAsyncCallback;
+ bool m_breakRequested = false;
+
v8::debug::ExceptionBreakState m_pauseOnExceptionsState;
WasmTranslation m_wasmTranslation;
« no previous file with comments | « src/api.cc ('k') | src/inspector/v8-debugger.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698