Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(57)

Unified Diff: src/inspector/v8-debugger-agent-impl.cc

Issue 2746743002: [inspector] support setTimeout in Debugger.scheduleStepIntoAsync method (Closed)
Patch Set: addressed comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: src/inspector/v8-debugger-agent-impl.cc
diff --git a/src/inspector/v8-debugger-agent-impl.cc b/src/inspector/v8-debugger-agent-impl.cc
index 75a7a3fe8e8b372497945cfd106439812960618e..5279b051396af1434028e8ad2493443d768d006b 100644
--- a/src/inspector/v8-debugger-agent-impl.cc
+++ b/src/inspector/v8-debugger-agent-impl.cc
@@ -746,18 +746,8 @@ void V8DebuggerAgentImpl::scheduleStepIntoAsync(
callback->sendFailure(Response::Error(kDebuggerNotPaused));
return;
}
- if (m_stepIntoAsyncCallback) {
- m_stepIntoAsyncCallback->sendFailure(Response::Error(
- "Current scheduled step into async was overriden with new one."));
- }
- m_stepIntoAsyncCallback = std::move(callback);
-}
-
-bool V8DebuggerAgentImpl::shouldBreakInScheduledAsyncTask() {
- if (!m_stepIntoAsyncCallback) return false;
- m_stepIntoAsyncCallback->sendSuccess();
- m_stepIntoAsyncCallback.reset();
- return true;
+ m_debugger->scheduleStepIntoAsync(std::move(callback),
+ m_session->contextGroupId());
}
Response V8DebuggerAgentImpl::setPauseOnExceptions(
@@ -1230,12 +1220,6 @@ void V8DebuggerAgentImpl::didPause(int contextId,
breakAuxData->setArray("reasons", std::move(reasons));
}
- if (m_stepIntoAsyncCallback) {
- m_stepIntoAsyncCallback->sendFailure(
- Response::Error("No async tasks were scheduled before pause."));
- m_stepIntoAsyncCallback.reset();
- }
-
std::unique_ptr<Array<CallFrame>> protocolCallFrames;
Response response = currentCallFrames(&protocolCallFrames);
if (!response.isSuccess()) protocolCallFrames = Array<CallFrame>::create();
« no previous file with comments | « src/inspector/v8-debugger-agent-impl.h ('k') | test/inspector/debugger/schedule-step-into-async-set-timeout.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698