Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Unified Diff: chrome/browser/android/webapk/webapk_installer.h

Issue 2746723002: [WebAPK] Refactor "unsigned sources" installation path (Closed)
Patch Set: Merge branch 'master' into start Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/android/webapk/webapk_installer.h
diff --git a/chrome/browser/android/webapk/webapk_installer.h b/chrome/browser/android/webapk/webapk_installer.h
index 0f0f3252e0bd26aa5f5eb64c2153a0f62d30db98..ea049d7fb428c7f9261a75e65bd551845bad4c1d 100644
--- a/chrome/browser/android/webapk/webapk_installer.h
+++ b/chrome/browser/android/webapk/webapk_installer.h
@@ -110,19 +110,17 @@ class WebApkInstaller : public net::URLFetcherDelegate {
const ShortcutInfo& shortcut_info,
const SkBitmap& shortcut_icon);
- // Starts installation of the downloaded WebAPK. Returns whether the install
- // could be started. The installation may still fail if true is returned.
+ // Starts installion of the downloaded WebAPK.
// |file_path| is the file path that the WebAPK was downloaded to.
- // |package_name| is the package name that the WebAPK should be installed at.
- virtual bool StartInstallingDownloadedWebApk(
+ // |package_name| is the package name of the WebAPK.
+ virtual void InstallDownloadedWebApk(
JNIEnv* env,
const base::android::ScopedJavaLocalRef<jstring>& java_file_path,
const base::android::ScopedJavaLocalRef<jstring>& java_package_name);
- // Starts update using the downloaded WebAPK. Returns whether the updating
- // could be started. The updating may still fail if true is returned.
+ // Starts update using the downloaded WebAPK.
// |file_path| is the file path that the WebAPK was downloaded to.
- virtual bool StartUpdateUsingDownloadedWebApk(
+ virtual void UpdateUsingDownloadedWebApk(
JNIEnv* env,
const base::android::ScopedJavaLocalRef<jstring>& java_file_path);

Powered by Google App Engine
This is Rietveld 408576698