third_party/WebKit/Source/bindings/scripts/v8_union.py - Issue 2746713003: bindings: Add support for nested union types

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/scripts/v8_union.py

Issue 2746713003: bindings: Add support for nested union types (Closed)

Patch Set: Improve documentation Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/bindings/scripts/v8_union.py

diff --git a/third_party/WebKit/Source/bindings/scripts/v8_union.py b/third_party/WebKit/Source/bindings/scripts/v8_union.py

index e1464a4905f702c7bef191d8486873835a99e559..c277fb598cb5f74c4c41cd72de4e8dc8a2279804 100644

--- a/third_party/WebKit/Source/bindings/scripts/v8_union.py

+++ b/third_party/WebKit/Source/bindings/scripts/v8_union.py

@@ -54,7 +54,7 @@ def container_context(union_type, interfaces_info):

object_type = None

record_type = None

string_type = None

- for member in sorted(union_type.member_types, key=lambda m: m.name):

+ for member in sorted(union_type.flattened_member_types, key=lambda m: m.name):

context = member_context(member, interfaces_info)

members.append(context)

if member.base_type == 'ArrayBuffer':