Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp

Issue 2746583003: Send deprecation messages for prefixed gradients now that it's possible. (Closed)
Patch Set: fix tests 2 Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
index a1e71148e69cbcde6f7da7abe247204457c31ca4..69700bdc3245f24afb529c1d887871efe65f1c7d 100644
--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParserHelpers.cpp
@@ -1223,13 +1223,12 @@ static CSSValue* consumeGeneratedImage(CSSParserTokenRange& range,
} else if (id == CSSValueRepeatingRadialGradient) {
result = consumeRadialGradient(args, context->mode(), Repeating);
} else if (id == CSSValueWebkitLinearGradient) {
- // FIXME: This should send a deprecation message.
- context->count(UseCounter::DeprecatedWebKitLinearGradient);
+ context->countDeprecation(UseCounter::DeprecatedWebKitLinearGradient);
result = consumeLinearGradient(args, context->mode(), NonRepeating,
CSSPrefixedLinearGradient);
} else if (id == CSSValueWebkitRepeatingLinearGradient) {
- // FIXME: This should send a deprecation message.
- context->count(UseCounter::DeprecatedWebKitRepeatingLinearGradient);
+ context->countDeprecation(
+ UseCounter::DeprecatedWebKitRepeatingLinearGradient);
result = consumeLinearGradient(args, context->mode(), Repeating,
CSSPrefixedLinearGradient);
} else if (id == CSSValueRepeatingLinearGradient) {
@@ -1239,16 +1238,15 @@ static CSSValue* consumeGeneratedImage(CSSParserTokenRange& range,
result = consumeLinearGradient(args, context->mode(), NonRepeating,
CSSLinearGradient);
} else if (id == CSSValueWebkitGradient) {
- // FIXME: This should send a deprecation message.
- context->count(UseCounter::DeprecatedWebKitGradient);
+ context->countDeprecation(UseCounter::DeprecatedWebKitGradient);
result = consumeDeprecatedGradient(args, context->mode());
} else if (id == CSSValueWebkitRadialGradient) {
- // FIXME: This should send a deprecation message.
- context->count(UseCounter::DeprecatedWebKitRadialGradient);
+ context->countDeprecation(UseCounter::DeprecatedWebKitRadialGradient);
result =
consumeDeprecatedRadialGradient(args, context->mode(), NonRepeating);
} else if (id == CSSValueWebkitRepeatingRadialGradient) {
- context->count(UseCounter::DeprecatedWebKitRepeatingRadialGradient);
+ context->countDeprecation(
+ UseCounter::DeprecatedWebKitRepeatingRadialGradient);
result = consumeDeprecatedRadialGradient(args, context->mode(), Repeating);
} else if (id == CSSValueWebkitCrossFade) {
result = consumeCrossFade(args, context);

Powered by Google App Engine
This is Rietveld 408576698