[Sensors] Implement bindings for AbsoluteOrientationSensor

third_party/WebKit/Source/modules/sensor/SensorProxy.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef SensorProxy_h
 #define SensorProxy_h
 
 #include "core/dom/ExceptionCode.h"
 #include "core/page/PageVisibilityObserver.h"
 #include "device/generic_sensor/public/cpp/sensor_reading.h"
@@ skipping 13 matching lines @@
 // This class wraps 'Sensor' mojo interface and used by multiple
 // JS sensor instances of the same type (within a single frame).
 class SensorProxy final : public GarbageCollectedFinalized<SensorProxy>,
                           public device::mojom::blink::SensorClient,
                           public PageVisibilityObserver {
   USING_GARBAGE_COLLECTED_MIXIN(SensorProxy);
   USING_PRE_FINALIZER(SensorProxy, dispose);
   WTF_MAKE_NONCOPYABLE(SensorProxy);
 
  public:
-  class Observer : public GarbageCollectedMixin {
+  class Client : public GarbageCollectedMixin {

[Reilly Grant (use Gerrit), 2017/03/24 15:10:33]

Why rename this? It is an observer.

[Mikhail, 2017/03/24 16:30:31]

Agree, the newly added method is actually notification too, renamed it back :)
thanks!

    public:
     // Has valid 'Sensor' binding, {add, remove}Configuration()
     // methods can be called.
     virtual void onSensorInitialized() {}
     // Platfrom sensort reading has changed.

[Reilly Grant (use Gerrit), 2017/03/24 15:10:33]

sensort -> sensor

[Mikhail, 2017/03/24 16:30:31]

Done.

+    virtual void onSensorReadingChanged() {}
+    // Client should send 'onchange' event if needed.
+    // The 'notifySensorChanged' calls are in sync with rAF.
+    // Currently, we decide whether to send 'onchange' event based on the
+    // time elapsed from the previous notification.
+    // TODO: Reconsider this after https://github.com/w3c/sensors/issues/152
+    // is resolved.
     // |timestamp| Reference timestamp in seconds of the moment when
     // sensor reading was updated from the buffer.
     // Note: |timestamp| values are only used to calculate elapsed time
     // between shared buffer readings. These values *do not* correspond
     // to sensor reading timestamps which are obtained on platform side.
-    virtual void onSensorReadingChanged(double timestamp) {}
+    virtual void notifySensorChanged(double timestamp) {}
     // An error has occurred.
     virtual void onSensorError(ExceptionCode,
                                const String& sanitizedMessage,
                                const String& unsanitizedMessage) {}
   };
 
   ~SensorProxy();
 
   void dispose();
 
-  void addObserver(Observer*);
-  void removeObserver(Observer*);
+  void addClient(Client*);
+  void removeClient(Client*);
 
   void initialize();
 
   bool isInitializing() const { return m_state == Initializing; }
   bool isInitialized() const { return m_state == Initialized; }
 
   // Is watching new reading data (initialized, not suspended and has
   // configurations added).
   bool isActive() const;
 
@@ skipping 52 matching lines @@
       std::unique_ptr<Function<void(bool)>> callback,
       bool result);
   void onRemoveConfigurationCompleted(double frequency, bool result);
 
   bool tryReadFromBuffer(device::SensorReading& result);
   void onAnimationFrame(double timestamp);
 
   device::mojom::blink::SensorType m_type;
   device::mojom::blink::ReportingMode m_mode;
   Member<SensorProviderProxy> m_provider;
-  using ObserversSet = HeapHashSet<WeakMember<Observer>>;
-  ObserversSet m_observers;
+  using ClientsSet = HeapHashSet<WeakMember<Client>>;
+  ClientsSet m_clients;
 
   device::mojom::blink::SensorPtr m_sensor;
   device::mojom::blink::SensorConfigurationPtr m_defaultConfig;
   mojo::Binding<device::mojom::blink::SensorClient> m_clientBinding;
 
   enum State { Uninitialized, Initializing, Initialized };
   State m_state;
   mojo::ScopedSharedBufferHandle m_sharedBufferHandle;
   mojo::ScopedSharedBufferMapping m_sharedBuffer;
   bool m_suspended;
   device::SensorReading m_reading;
   std::pair<double, double> m_frequencyLimits;
 
   Member<SensorReadingUpdater> m_readingUpdater;
   WTF::Vector<double> m_frequenciesUsed;
   double m_lastRafTimestamp;
 
   using ReadingBuffer = device::SensorReadingSharedBuffer;
   static_assert(
       sizeof(ReadingBuffer) ==
           device::mojom::blink::SensorInitParams::kReadBufferSizeForTests,
       "Check reading buffer size for tests");
 };
 
 }  // namespace blink
 
 #endif  // SensorProxy_h