[Sensors] Implement bindings for AbsoluteOrientationSensor

third_party/WebKit/Source/modules/sensor/SensorProxy.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/sensor/SensorProxy.h"
 
 #include "core/dom/Document.h"
 #include "core/frame/LocalFrame.h"
 #include "modules/sensor/SensorProviderProxy.h"
 #include "modules/sensor/SensorReadingUpdater.h"
@@ skipping 16 matching lines @@
       m_suspended(false) {}
 
 SensorProxy::~SensorProxy() {}
 
 void SensorProxy::dispose() {
   m_clientBinding.Close();
 }
 
 DEFINE_TRACE(SensorProxy) {
   visitor->trace(m_readingUpdater);
-  visitor->trace(m_observers);
+  visitor->trace(m_clients);
   visitor->trace(m_provider);
   PageVisibilityObserver::trace(visitor);
 }
 
-void SensorProxy::addObserver(Observer* observer) {
-  if (!m_observers.contains(observer))
-    m_observers.insert(observer);
+void SensorProxy::addClient(Client* client) {
+  if (!m_clients.contains(client))
+    m_clients.insert(client);
 }
 
-void SensorProxy::removeObserver(Observer* observer) {
-  m_observers.erase(observer);
+void SensorProxy::removeClient(Client* client) {
+  m_clients.erase(client);
 }
 
 void SensorProxy::initialize() {
   if (m_state != Uninitialized)
     return;
 
   if (!m_provider->getSensorProvider()) {
     handleSensorError();
     return;
   }
@@ skipping 63 matching lines @@
   int readAttempts = 0;
   const int kMaxReadAttemptsCount = 10;
   device::SensorReading readingData;
   while (!tryReadFromBuffer(readingData)) {
     if (++readAttempts == kMaxReadAttemptsCount) {
       handleSensorError();
       return;
     }
   }
 
-  m_reading = readingData;
+  if (m_reading.timestamp != readingData.timestamp) {
+    m_reading = readingData;
+    for (Client* client : m_clients)
+      client->onSensorReadingChanged();
+  }
 }
 
 void SensorProxy::notifySensorChanged(double timestamp) {
   // This notification leads to sync 'onchange' event sending, so
-  // we must cache m_observers as it can be modified within event handlers.
-  auto copy = m_observers;
-  for (Observer* observer : copy)
-    observer->onSensorReadingChanged(timestamp);
+  // we must cache m_clients as it can be modified within event handlers.
+  auto copy = m_clients;
+  for (Client* client : copy)
+    client->notifySensorChanged(timestamp);
 }
 
 void SensorProxy::RaiseError() {
   handleSensorError();
 }
 
 void SensorProxy::SensorReadingChanged() {
   DCHECK_EQ(ReportingMode::ON_CHANGE, m_mode);
   if (isActive())
     m_readingUpdater->start();
@@ skipping 16 matching lines @@
   m_reading = device::SensorReading();
 
   // The m_sensor.reset() will release all callbacks and its bound parameters,
   // therefore, handleSensorError accepts messages by value.
   m_sensor.reset();
   m_sharedBuffer.reset();
   m_sharedBufferHandle.reset();
   m_defaultConfig.reset();
   m_clientBinding.Close();
 
-  for (Observer* observer : m_observers) {
-    observer->onSensorError(NotReadableError, "Could not connect to a sensor",
-                            String());
+  for (Client* client : m_clients) {
+    client->onSensorError(NotReadableError, "Could not connect to a sensor",
+                          String());
   }
 }
 
 void SensorProxy::onSensorCreated(SensorInitParamsPtr params,
                                   SensorClientRequest clientRequest) {
   DCHECK_EQ(Initializing, m_state);
   if (!params) {
     handleSensorError();
     return;
   }
@@ skipping 31 matching lines @@
 
   auto errorCallback =
       WTF::bind(&SensorProxy::handleSensorError, wrapWeakPersistent(this));
   m_sensor.set_connection_error_handler(
       convertToBaseCallback(std::move(errorCallback)));
 
   m_readingUpdater = SensorReadingUpdater::create(this, m_mode);
 
   m_state = Initialized;
 
-  for (Observer* observer : m_observers)
-    observer->onSensorInitialized();
+  for (Client* client : m_clients)
+    client->onSensorInitialized();
 }
 
 void SensorProxy::onAddConfigurationCompleted(
     double frequency,
     std::unique_ptr<Function<void(bool)>> callback,
     bool result) {
   if (result) {
     m_frequenciesUsed.push_back(frequency);
     std::sort(m_frequenciesUsed.begin(), m_frequenciesUsed.end());
     if (isActive())
@@ skipping 24 matching lines @@
   const device::OneWriterSeqLock& seqlock = buffer->seqlock.value();
   auto version = seqlock.ReadBegin();
   auto readingData = buffer->reading;
   if (seqlock.ReadRetry(version))
     return false;
   result = readingData;
   return true;
 }
 
 }  // namespace blink