[Sensors] Implement bindings for AbsoluteOrientationSensor

third_party/WebKit/Source/modules/sensor/Sensor.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "modules/sensor/Sensor.h"
 
 #include "core/dom/Document.h"
 #include "core/dom/ExceptionCode.h"
 #include "core/dom/TaskRunnerHelper.h"
 #include "core/inspector/ConsoleMessage.h"
@@ skipping 145 matching lines @@
   if (frequency > maximumFrequency)
     frequency = maximumFrequency;
   if (frequency < minimumFrequency)
     frequency = minimumFrequency;
 
   result->frequency = frequency;
   return result;
 }
 
 double Sensor::readingValue(int index, bool& isNull) const {
-  if (!canReturnReadings()) {
-    isNull = true;
-    return 0.0;
-  }
+  isNull = !canReturnReadings();
+  return isNull ? 0.0 : readingValueUnchecked(index);
+}
+
+double Sensor::readingValueUnchecked(int index) const {
   DCHECK(m_sensorProxy);
   DCHECK(index >= 0 && index < device::SensorReading::kValuesCount);
   return m_sensorProxy->reading().values[index];
 }
 
 void Sensor::initSensorProxyIfNeeded() {
   if (m_sensorProxy)
     return;
 
   Document* document = toDocument(getExecutionContext());
@@ skipping 13 matching lines @@
     stopListening();
 }
 
 void Sensor::onSensorInitialized() {
   if (m_state != Sensor::SensorState::Activating)
     return;
 
   startListening();
 }
 
-void Sensor::onSensorReadingChanged(double timestamp) {
+void Sensor::notifySensorChanged(double timestamp) {
   if (m_state != Sensor::SensorState::Activated)
     return;
 
   DCHECK_GT(m_configuration->frequency, 0.0);
   double period = 1 / m_configuration->frequency;
+
   if (timestamp - m_lastUpdateTimestamp >= period) {
     m_lastUpdateTimestamp = timestamp;
     notifySensorReadingChanged();
   }
 }
 
 void Sensor::onSensorError(ExceptionCode code,
                            const String& sanitizedMessage,
                            const String& unsanitizedMessage) {
   reportError(code, sanitizedMessage, unsanitizedMessage);
@@ skipping 10 matching lines @@
     return;
   }
 
   updateState(Sensor::SensorState::Activated);
 }
 
 void Sensor::startListening() {
   DCHECK(m_sensorProxy);
   updateState(Sensor::SensorState::Activating);
 
-  m_sensorProxy->addObserver(this);
+  m_sensorProxy->addClient(this);
   if (!m_sensorProxy->isInitialized()) {
     m_sensorProxy->initialize();
     return;
   }
 
   if (!m_configuration) {
     m_configuration = createSensorConfig();
     DCHECK(m_configuration);
     DCHECK(m_configuration->frequency > 0 &&
            m_configuration->frequency <=
                SensorConfiguration::kMaxAllowedFrequency);
   }
 
   auto startCallback =
       WTF::bind(&Sensor::onStartRequestCompleted, wrapWeakPersistent(this));
   m_sensorProxy->addConfiguration(m_configuration->Clone(),
                                   std::move(startCallback));
 }
 
 void Sensor::stopListening() {
   DCHECK(m_sensorProxy);
   updateState(Sensor::SensorState::Idle);
 
   if (m_sensorProxy->isInitialized()) {
     DCHECK(m_configuration);
     m_sensorProxy->removeConfiguration(m_configuration->Clone());
   }
-  m_sensorProxy->removeObserver(this);
+  m_sensorProxy->removeClient(this);
 }
 
 void Sensor::updateState(Sensor::SensorState newState) {
   if (newState == m_state)
     return;
 
   if (newState == SensorState::Activated && getExecutionContext()) {
     DCHECK_EQ(SensorState::Activating, m_state);
     // The initial value for m_lastUpdateTimestamp is set to current time,
     // so that the first reading update will be notified considering the given
@@ skipping 33 matching lines @@
 void Sensor::notifyOnActivate() {
   dispatchEvent(Event::create(EventTypeNames::activate));
 }
 
 void Sensor::notifyError(DOMException* error) {
   dispatchEvent(
       SensorErrorEvent::create(EventTypeNames::error, std::move(error)));
 }
 
 bool Sensor::canReturnReadings() const {
-  if (m_state != Sensor::SensorState::Activated)
+  if (!isActivated())
     return false;
   DCHECK(m_sensorProxy);
   return m_sensorProxy->reading().timestamp != 0.0;
 }
 
 }  // namespace blink